Skip to content

Commit f6b433d

Browse files
SP-1184 - change COMPOSER_AUTH to MAGENTO_MARKETPLACE_USERNAME and MAGENTO_MARKETPLACE_PASSWORD
1 parent b0d9bd9 commit f6b433d

File tree

2 files changed

+12
-7
lines changed

2 files changed

+12
-7
lines changed

.github/2.4.8/php-8.4/Dockerfile

+2
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,8 @@ ENV PROJECT_NAME=$PROJECT_NAME
4444
ENV PHPUNIT_FILE=$PHPUNIT_FILE
4545
ENV GITHUB_WORKSPACE=$GITHUB_WORKSPACE
4646
ENV COMPOSER_AUTH=$COMPOSER_AUTH
47+
ENV MAGENTO_MARKETPLACE_USERNAME=$MAGENTO_MARKETPLACE_USERNAME
48+
ENV MAGENTO_MARKETPLACE_PASSWORD=$MAGENTO_MARKETPLACE_PASSWORD
4749

4850
COPY .github/2.4.8/php-8.4/entrypoint.sh /entrypoint.sh
4951
RUN chmod 755 /entrypoint.sh

.github/workflows/test.yml

+10-7
Original file line numberDiff line numberDiff line change
@@ -34,9 +34,10 @@ jobs:
3434
with:
3535
magento_pre_install_script: "./.github/2.4.8/test-pre-install-script.sh"
3636
env:
37-
COMPOSER_AUTH: ${{ secrets.COMPOSER_AUTH }}
38-
MAGENTO_VERSION: ${{ matrix.MAGENTO_VERSION }}
3937
PHPUNIT_FILE: ".github/2.4.8/phpunit.xml"
38+
MAGENTO_MARKETPLACE_USERNAME: ${{ secrets.MAGENTO_MARKETPLACE_USERNAME }}
39+
MAGENTO_MARKETPLACE_PASSWORD: ${{ secrets.MAGENTO_MARKETPLACE_PASSWORD }}
40+
MAGENTO_VERSION: ${{ matrix.MAGENTO_VERSION }}
4041

4142
unit-tests-83:
4243
name: Unit Tests (PHP 8.3)
@@ -52,7 +53,8 @@ jobs:
5253
magento_pre_install_script: "./.github/2.4.8/test-pre-install-script.sh"
5354
env:
5455
PHPUNIT_FILE: ".github/2.4.8/phpunit.xml"
55-
COMPOSER_AUTH: ${{ secrets.COMPOSER_AUTH }}
56+
MAGENTO_MARKETPLACE_USERNAME: ${{ secrets.MAGENTO_MARKETPLACE_USERNAME }}
57+
MAGENTO_MARKETPLACE_PASSWORD: ${{ secrets.MAGENTO_MARKETPLACE_PASSWORD }}
5658
MAGENTO_VERSION: ${{ matrix.MAGENTO_VERSION }}
5759

5860
unit-tests-84:
@@ -64,13 +66,14 @@ jobs:
6466
MAGENTO_VERSION: ["2.4.8-beta2"]
6567
steps:
6668
- uses: actions/checkout@v4
67-
- name: Build docker images
69+
- name: Build docker image
6870
run: docker build -f .github/2.4.8/php-8.4/Dockerfile -t local .
69-
- name: Run docker images
70-
run: docker run -e GITHUB_WORKSPACE=$GITHUB_WORKSPACE -e MODULE_NAME=$MODULE_NAME -e MODULE_SOURCE=$MODULE_SOURCE -e COMPOSER_NAME=$COMPOSER_NAME -e MAGENTO_VERSION=$MAGENTO_VERSION -e PROJECT_NAME=$PROJECT_NAME -e PHPUNIT_FILE=$PHPUNIT_FILE -e COMPOSER_AUTH=$COMPOSER_AUTH local
71+
- name: Run docker image
72+
run: docker run -e GITHUB_WORKSPACE=$GITHUB_WORKSPACE -e MODULE_NAME=$MODULE_NAME -e MODULE_SOURCE=$MODULE_SOURCE -e COMPOSER_NAME=$COMPOSER_NAME -e MAGENTO_VERSION=$MAGENTO_VERSION -e PROJECT_NAME=$PROJECT_NAME -e PHPUNIT_FILE=$PHPUNIT_FILE -e MAGENTO_MARKETPLACE_USERNAME=$MAGENTO_MARKETPLACE_USERNAME -e MAGENTO_MARKETPLACE_PASSWORD=$MAGENTO_MARKETPLACE_PASSWORD local
7173
env:
7274
PHPUNIT_FILE: ".github/2.4.8/phpunit.xml"
73-
COMPOSER_AUTH: ${{ secrets.COMPOSER_AUTH }}
75+
MAGENTO_MARKETPLACE_USERNAME: ${{ secrets.MAGENTO_MARKETPLACE_USERNAME }}
76+
MAGENTO_MARKETPLACE_PASSWORD: ${{ secrets.MAGENTO_MARKETPLACE_PASSWORD }}
7477
MAGENTO_VERSION: ${{ matrix.MAGENTO_VERSION }}
7578
GITHUB_WORKSPACE: ${{ github.workspace }}
7679

0 commit comments

Comments
 (0)