Fix SG naming

LeoDiazL · web-flow · commit 4e5dba9003d2 · 2023-04-13T11:25:14.000-03:00
diff --git a/operations/deployment/terraform/postgres.tf b/operations/deployment/terraform/postgres.tf
@@ -1,6 +1,6 @@
 resource "aws_security_group" "pg_security_group" {
   count = var.aws_enable_postgres == "true" ? 1 : 0
-  name        = var.aws_security_group_name_pg
+  name        = var.aws_security_group_name_pg != "" ? var.aws_security_group_name_pg : "SG for ${var.aws_resource_identifier} - PG"
   description = "SG for ${var.aws_resource_identifier} - PG"
   egress {
     from_port   = 0
diff --git a/operations/deployment/terraform/security-group.tf b/operations/deployment/terraform/security-group.tf
@@ -1,5 +1,5 @@
 resource "aws_security_group" "ec2_security_group" {
-  name        = var.security_group_name
+  name        = var.security_group_name != "" ? var.security_group_name : "SG for ${var.aws_resource_identifier} - EC2"
   description = "SG for ${var.aws_resource_identifier}"
   vpc_id      = data.aws_vpc.default.id
   egress {
diff --git a/operations/deployment/terraform/variables.tf b/operations/deployment/terraform/variables.tf
@@ -61,12 +61,12 @@ variable "ec2_volume_size" {
 
 variable "security_group_name" {
   type        = string
-  default     = "SG for deployment"
+  default     = ""
   description = "Name of the security group to use"
 }
 variable "aws_security_group_name_pg" {
   type        = string
-  default     = "SG for postgres deployment"
+  default     = ""
   description = "Name of the security group to use for postgres"
 }
 variable "ec2_iam_instance_profile" {

Original file line number	Diff line number	Diff line change
`@@ -61,12 +61,12 @@ variable "ec2_volume_size" {`
`61`	`61`
`62`	`62`	`variable "security_group_name" {`
`63`	`63`	`type = string`
`64`		`- default = "SG for deployment"`
	`64`	`+ default = ""`
`65`	`65`	`description = "Name of the security group to use"`
`66`	`66`	`}`
`67`	`67`	`variable "aws_security_group_name_pg" {`
`68`	`68`	`type = string`
`69`		`- default = "SG for postgres deployment"`
	`69`	`+ default = ""`
`70`	`70`	`description = "Name of the security group to use for postgres"`
`71`	`71`	`}`
`72`	`72`	`variable "ec2_iam_instance_profile" {`