Fix aurora deletion parameter group (#62)

* Testing with removing the lifecycle block

* Test snap name change

* Snapshot overwrite

* testing alternative

* testing sth that won't work

* removing lifecycle block

* Fix README

* Adding a time-sleep

* adding lifecycle

* Don't think this will work

* no again

* Changing db_cluster_param_group_name

* missing index

* typo

* Cleanup

* cleanup 2

Author: LeoDiazL

README.md

@@ -257,7 +257,7 @@ The following inputs can be used as `step.with` keys
 #### **Aurora Inputs**
 | Name             | Type    | Description                        |
 |------------------|---------|------------------------------------|
-| `aws_aurora_enable` | Boolean | Toggles deployment of an Aurora database. Defaults to `true`. |
+| `aws_aurora_enable` | Boolean | Toggles deployment of an Aurora database. Defaults to `false`. |
 | `aws_aurora_proxy` | Boolean | Aurora DB Proxy Toggle. Defaults to `false`. |
 | `aws_aurora_cluster_name` | String | The name of the cluster. Defaults to `aws_resource_identifier` if none set. |
 | `aws_aurora_engine` | String | The database engine to use. Defaults to `aurora-postgresql`. |
@@ -293,12 +293,12 @@ The following inputs can be used as `step.with` keys
 | `aws_aurora_backup_window` | String | Daily time range during which the backups happen. |
 | `aws_aurora_maintenance_window` | String | Maintenance window. |
 | `aws_aurora_database_final_snapshot` | String | Set the name to generate a snapshot of the database before deletion. |
-| `aws_aurora_deletion_protection` | Boolean | Protects the database from deletion. Defaults to `false`. This won't prevent Terraform from destroying it. |
+| `aws_aurora_deletion_protection` | Boolean | Protects the database from deletion. Defaults to `false`.  **This won't prevent db instances to be deleted.** |
 | `aws_aurora_delete_auto_backups` | Boolean | Specifies whether to remove automated backups immediately after the DB cluster is deleted. Default is `true`. |
 | `aws_aurora_restore_snapshot_id` | String | Restore an initial snapshot of the DB if specified. |
 | `aws_aurora_restore_to_point_in_time` | map{String} | Restore database to a point in time. Will require a map of strings. Like `{"restore_to_time"="W","restore_type"="X","source_cluster_identifier"="Y", "use_latest_restorable_time"="Z"}`. Default `{}`. |
-| `aws_aurora_snapshot_name` | String | Takes a snapshot of the DB. |
-| `aws_aurora_snapshot_overwrite` | Boolean | Overwrites snapshot if same name is set. Defaults to `false`. |
+| `aws_aurora_snapshot_name` | String | Takes a snapshot of the DB. This is treated as one resource, meaning only one can be created, even if name changes.|
+| `aws_aurora_snapshot_overwrite` | Boolean | Takes a snapshot of the DB deleteing the previous snapshot. Defaults to `false`. |
 | **DB Instance** |||
 | `aws_aurora_db_instances_count` | String | Amount of instances to create. Defaults to `1`. |
 | `aws_aurora_db_instance_class` | String | Database instance size. Defaults to `db.r6g.large`. |

operations/deployment/terraform/modules/aws/aurora/aws_aurora.tf

@@ -74,7 +74,7 @@ resource "aws_rds_cluster" "aurora" {
   master_password                     = sensitive(random_password.rds.result)
   iam_database_authentication_enabled = var.aws_aurora_iam_auth_enabled
   iam_roles                           = var.aws_aurora_iam_roles != "" ? [var.aws_aurora_iam_roles] : []
-  db_cluster_parameter_group_name     = var.aws_resource_identifier
+  db_cluster_parameter_group_name     = strcontains(var.aws_aurora_engine, "mysql") ? aws_rds_cluster_parameter_group.mysql[0].name : strcontains(var.aws_aurora_engine, "postgres") ?  aws_rds_cluster_parameter_group.postgresql[0].name : "" 
   # Backup & Maint
   enabled_cloudwatch_logs_exports     = var.aws_aurora_cloudwatch_enable ? local.aws_aurora_cloudwatch_log_type : []
   backtrack_window                    = var.aws_aurora_backtrack_window 
@@ -129,10 +129,10 @@ resource "aws_rds_cluster_instance" "cluster_instance" {
   ca_cert_identifier           = var.aws_aurora_db_ca_cert_identifier
   preferred_maintenance_window = var.aws_aurora_db_maintenance_window
 }
-
+ 
 resource "aws_rds_cluster_parameter_group" "mysql" {
   count       = strcontains(var.aws_aurora_engine, "mysql") ? 1 : 0
-  name        = var.aws_resource_identifier
+  name        = "${var.aws_resource_identifier}-mysql"
   description = "${var.aws_resource_identifier} cluster parameter group"
   family      = var.aws_aurora_database_group_family != "" ? var.aws_aurora_database_group_family : "${var.aws_aurora_engine}8.0"
 
@@ -141,15 +141,14 @@ resource "aws_rds_cluster_parameter_group" "mysql" {
       value        = "ON"
       apply_method = "immediate"
   }
-
   lifecycle {
     create_before_destroy = true
   }
 }
 
 resource "aws_rds_cluster_parameter_group" "postgresql" {
   count       = strcontains(var.aws_aurora_engine, "postgres")? 1 : 0
-  name        = var.aws_resource_identifier
+  name        = "${var.aws_resource_identifier}-postgres"
   description = "${var.aws_resource_identifier} cluster parameter group"
   family      = var.aws_aurora_database_group_family != "" ? var.aws_aurora_database_group_family : "${var.aws_aurora_engine}15"
 
@@ -218,7 +217,7 @@ resource "aws_cloudwatch_log_group" "logs" {
 ### All of this added to handle snapshots
 resource "aws_db_cluster_snapshot" "db_snapshot" {
   count                          = var.aws_aurora_snapshot_name != "" ? ( var.aws_aurora_snapshot_overwrite ? 0 : 1 ) : 0 
-  db_cluster_identifier          = var.aws_aurora_cluster_name != "" ? var.aws_aurora_cluster_name : var.aws_resource_identifier
+  db_cluster_identifier          = aws_rds_cluster.aurora.cluster_identifier
   db_cluster_snapshot_identifier = var.aws_aurora_snapshot_name
   lifecycle {
     ignore_changes = all
@@ -227,7 +226,7 @@ resource "aws_db_cluster_snapshot" "db_snapshot" {
 
 resource "aws_db_cluster_snapshot" "overwrite_db_snapshot" {
   count                          = var.aws_aurora_snapshot_name != "" ? ( var.aws_aurora_snapshot_overwrite ? 1 : 0 ) : 0
-  db_cluster_identifier          = var.aws_aurora_cluster_name != "" ? var.aws_aurora_cluster_name : var.aws_resource_identifier
+  db_cluster_identifier          = aws_rds_cluster.aurora.cluster_identifier
   db_cluster_snapshot_identifier = var.aws_aurora_snapshot_name
   lifecycle {
     create_before_destroy = true