Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitnami/keycloak] Remove builtin metrics from stacksmith #50025

Open
kamontat opened this issue Sep 26, 2023 · 7 comments
Open

[bitnami/keycloak] Remove builtin metrics from stacksmith #50025

kamontat opened this issue Sep 26, 2023 · 7 comments
Assignees
Labels
feature-request keycloak on-hold Issues or Pull Requests with this label will never be considered stale

Comments

@kamontat
Copy link

Name and Version

bitnami/keycloak:22.0.3

What is the problem this feature will solve?

Currently Keycloak package generated from stacksmith, contains built-in keycloak-metrics-spi-4.0.0, which is nice for most case. However, on my case I needs to customize and uses our internal metrics SPI, which conflict with what provides by keycloak-metrics-spi provider.

To prove my word:

  1. Download Keycloak from stacksmith-keycloak (noted that this link is from here
  2. Untar the result
  3. Navigated to ./files/keycloak/providers/ after untar
  4. You will see keycloak-metrics-spi-4.0.0.jar file

What is the feature you are proposing to solve the problem?

Remove built-ins providers and download on build-time instead.

What alternatives have you considered?

No response

@github-actions github-actions bot added the triage Triage is needed label Sep 26, 2023
@javsalgar javsalgar changed the title [Keycloak] Remove builtin metrics from stacksmith [bitnami/keycloak] Remove builtin metrics from stacksmith Sep 27, 2023
@javsalgar
Copy link
Contributor

Hi,

Did you try mounting your own jar file overriding the existing one?

@kamontat
Copy link
Author

@javsalgar Yes, it works. But it seem to be just temporary solution.

@javsalgar
Copy link
Contributor

If you need to modify the default SPI metrics provided by keycloak, you can either do this or create your own fork, as this seems to be a very specific use case not taken into account by keycloak devs if I'm not mistaken.

@kamontat
Copy link
Author

kamontat commented Oct 2, 2023

@javsalgar keycloak-metrics-spi-4.0.0.jar is not a SPI provided by Keycloak, it actually a third-party metrics from https://github.com/aerogear/keycloak-metrics-spi.

@javsalgar
Copy link
Contributor

Would it make sense to have an environment variable to disable the included metrics spi?

@kamontat
Copy link
Author

kamontat commented Oct 5, 2023

@javsalgar Yes, if possible.

@github-actions github-actions bot added in-progress and removed triage Triage is needed labels Oct 6, 2023
@bitnami-bot bitnami-bot assigned dgomezleon and unassigned javsalgar Oct 6, 2023
@dgomezleon
Copy link
Member

Hi @kamontat ,

We have created a task for your proposal. We will let you know about any updates.

@dgomezleon dgomezleon added on-hold Issues or Pull Requests with this label will never be considered stale and removed in-progress labels Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request keycloak on-hold Issues or Pull Requests with this label will never be considered stale
Projects
None yet
Development

No branches or pull requests

3 participants