Skip to content

Commit c42b01b

Browse files
committed
Merge #1722: fix(testenv): disable downloads (bitcoind and electrsd) for docs.rs b…
9b48fd4 fix(testenv): disable downloads (bitcoind and electrsd) for docs.rs builds of crate testenv (River Kanies) Pull request description: …uilds of crate testenv ### Description address this issue #1627 where docs.rs build is failing for bdk_testenv crate original PR: #1679 ### Notes to the reviewers I was not able to reproduce the build issue locally, so this will have to be tested live unless someone else can reproduce the build error https://docs.rs/crate/bdk_testenv/0.10.0/builds/1377651 more details in this thread on discord https://discord.com/channels/753336465005608961/1265333904324427849/1304476756660719668 #### Bugfixes: * [x] I'm linking the issue being fixed by this PR ACKs for top commit: ValuedMammal: ACK 9b48fd4 but I guess we won't know for sure until we publish the crate notmandatory: ACK 9b48fd4 Tree-SHA512: fe4ad420f71530a279e1cf86af6e7bd59f381804a5c7c9636fa2aaa5592ff4e6fed668513831d7d63ed0a97152d685b187d50e906b21dbbb2180dedf5d28fad0
2 parents 3bc45b5 + 9b48fd4 commit c42b01b

File tree

4 files changed

+12
-5
lines changed

4 files changed

+12
-5
lines changed

crates/bitcoind_rpc/Cargo.toml

+1-1
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ bitcoincore-rpc = { version = "0.19.0" }
2121
bdk_core = { path = "../core", version = "0.3.0", default-features = false }
2222

2323
[dev-dependencies]
24-
bdk_testenv = { path = "../testenv", default-features = false }
24+
bdk_testenv = { path = "../testenv" }
2525
bdk_chain = { path = "../chain" }
2626

2727
[features]

crates/electrum/Cargo.toml

+1-1
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ bdk_core = { path = "../core", version = "0.3.0" }
1717
electrum-client = { version = "0.21", features = [ "proxy" ], default-features = false }
1818

1919
[dev-dependencies]
20-
bdk_testenv = { path = "../testenv", default-features = false }
20+
bdk_testenv = { path = "../testenv" }
2121
bdk_chain = { path = "../chain" }
2222

2323
[features]

crates/esplora/Cargo.toml

+1-1
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ miniscript = { version = "12.0.0", optional = true, default-features = false }
2323

2424
[dev-dependencies]
2525
bdk_chain = { path = "../chain" }
26-
bdk_testenv = { path = "../testenv", default-features = false }
26+
bdk_testenv = { path = "../testenv" }
2727
tokio = { version = "1", features = ["rt", "rt-multi-thread", "macros"] }
2828

2929
[features]

crates/testenv/Cargo.toml

+9-2
Original file line numberDiff line numberDiff line change
@@ -17,9 +17,16 @@ workspace = true
1717

1818
[dependencies]
1919
bdk_chain = { path = "../chain", version = "0.20.0", default-features = false }
20-
electrsd = { version = "0.28.0", features = [ "bitcoind_25_0", "esplora_a33e97e1", "legacy" ] }
20+
electrsd = { version = "0.28.0", features = [ "legacy" ], default-features = false }
21+
22+
[dev-dependencies]
23+
bdk_testenv = { path = "." }
2124

2225
[features]
23-
default = ["std"]
26+
default = ["std", "download"]
27+
download = ["electrsd/bitcoind_25_0", "electrsd/esplora_a33e97e1"]
2428
std = ["bdk_chain/std"]
2529
serde = ["bdk_chain/serde"]
30+
31+
[package.metadata.docs.rs]
32+
no-default-features = true

0 commit comments

Comments
 (0)