Feature Request: Report pathfinding outcomes to scorer in SimNode

[carlaKC]

Describe desired feature

While we have one scorer per node in SimNode, we're not actually reporting outcomes to the scorer once the payment has resolved. This should be done by importing the ScorerUpdate trait and reporting payment success/failure once we're done tracking the payment.

This will require that we:

1. Store the path that payments used so that we can report them (probably in SimNode.in_flight?)
2. Return the failing index from propagate_payment so that we can successfully report the failing channel

Use case for feature

This makes pathfinding (more) realistic.

Would you like to contribute code for this feature?

Happy to write code or review.

[chuksys]

Would like to pick this up.

[carlaKC]

I started a branch for this yesterday (should have assigned myself 😬 ) - would you be interested in taking it on? It's mostly a skeleton, needs a fair amount of shaping up still.

[chuksys]

Yes, I'd be happy to take it on!

[chuksys]

Just wanted to let you know – I'm planning to open the PR for this about a week from now. Thanks for your patience!

[carlaKC]

Thanks for the update 🙏 sgtm!