Skip to content

Commit 6450368

Browse files
committed
fixup! Address jesseposner's comments
1 parent 90df983 commit 6450368

File tree

1 file changed

+6
-5
lines changed

1 file changed

+6
-5
lines changed

include/secp256k1_schnorrsig.h

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -23,16 +23,16 @@ extern "C" {
2323
*
2424
* Returns: 1 if a nonce was successfully generated. 0 will cause signing to
2525
* return an error.
26-
* Out: nonce32: pointer to a 32-byte array to be filled by the function.
26+
* Out: nonce32: pointer to a 32-byte array to be filled by the function
2727
* In: msg: the message being verified (will not be NULL)
2828
* msglen: the length of the message (will not be NULL)
2929
* key32: pointer to a 32-byte secret key (will not be NULL)
3030
* xonly_pk32: the 32-byte serialized xonly pubkey corresponding to key32
3131
* (will not be NULL)
3232
* algo: pointer to an array describing the signature
33-
* algorithm (will not be NULL).
33+
* algorithm (will not be NULL)
3434
* algolen: the length of the algo array
35-
* data: Arbitrary data pointer that is passed through.
35+
* data: arbitrary data pointer that is passed through
3636
*
3737
* Except for test cases, this function should compute some cryptographic hash of
3838
* the message, the key, the pubkey, the algorithm description, and data.
@@ -98,15 +98,16 @@ typedef struct {
9898
* abort if it fails.
9999
*
100100
* This function only signs 32-byte messages. If you have messages of a
101-
* different size, it is recommended to create a 32-byte message hash with
101+
* different size (or the same size but without an application-specific tag
102+
* prefix), it is recommended to create a 32-byte message hash with
102103
* secp256k1_tagged_sha256 and then sign the hash. Tagged hashing allows
103104
* providing an application-specific tag for domain separation. This prevents
104105
* signatures from being valid in multiple applications by accident.
105106
*
106107
* Returns 1 on success, 0 on failure.
107108
* Args: ctx: pointer to a context object, initialized for signing (cannot be NULL)
108109
* Out: sig64: pointer to a 64-byte array to store the serialized signature (cannot be NULL)
109-
* In: msg32: the 32-byte message hash being signed (cannot be NULL)
110+
* In: msg32: the 32-byte message being signed (cannot be NULL)
110111
* keypair: pointer to an initialized keypair (cannot be NULL)
111112
* aux_rand32: 32 bytes of fresh randomness. While recommended to provide
112113
* this, it is only supplemental to security and can be NULL. See

0 commit comments

Comments
 (0)