Originating from geneontology/pipeline#242 (comment).
Use case here is converting a GPAD, which lacks aspect column, into GAF. For most annotations the null aspect is correctly filled in from the ontology term property hasOBONamespace. But this property is missing for obsolete terms (like GO:0044212), so the resulting GAF line will have a blank aspect column. To fix:
we want to aim to repair the obsoleted term (via GO rule 20) before attempting to extract the aspect in GO rule 28. This way the correct term (GO:0000976) is in place for aspect extraction.
So far, this reordering of rules just looks to involve moving up a few code lines in gpadparser.py. We may want to also do this in gafparser.py for consistency even though it's likely a non-issue for GAF inputs since the aspects are already explicitly set?
Activity
Repair obsolete terms before other GO rule tests; for #576
Merge pull request #577 from biolink/issue-576-obs-term-repair-aspect
kltm commentedon Jun 16, 2021
@dustine32 I guess this was a problem for geneontology/pipeline#242 , right?
Just to keep everybody at the same place, we can bump go-site
masterto2.7.6for ontobio and then have the test branches catch up there.update for geneontology/pipeline#242 and biolink/ontobio#576
sierra-moxon commentedon Jun 23, 2021
updated ZFIN branch and rerunning.