Skip to content

Commit c05bf7e

Browse files
committed
Merge pull request #4 from jasonamyers/master
Added allowoverwrite to unload statement, and fixed tests
2 parents 15642f9 + 4df70f3 commit c05bf7e

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

redshift_sqlalchemy/dialect.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -76,11 +76,12 @@ def __init__(self, select, bucket, access_key, secret_key):
7676
self.access_key = access_key
7777
self.secret_key = secret_key
7878

79+
7980
@compiles(UnloadFromSelect)
8081
def visit_unload_from_select(element, compiler, **kw):
8182
''' Returns the actual sql query for the UnloadFromSelect class
8283
'''
83-
return "unload ('%(query)s') to '%(bucket)s' credentials 'aws_access_key_id=%(access_key)s;aws_secret_access_key=%(secret_key)s' delimiter ',' addquotes" % {
84+
return "unload ('%(query)s') to '%(bucket)s' credentials 'aws_access_key_id=%(access_key)s;aws_secret_access_key=%(secret_key)s' delimiter ',' addquotes allowoverwrite" % {
8485
'query': compiler.process(element.select, unload_select=True, literal_binds=True),
8586
'bucket': element.bucket,
8687
'access_key': element.access_key,

tests/test_unload_from_select.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,6 @@ def setUp(self):
1414
def test_basic_unload_case(self):
1515
''' Tests that the simplest type of UnloadFromSelect works
1616
'''
17-
expected_result = "unload ('SELECT count(t1.id) AS count_1 \nFROM t1') to 'cookies' credentials 'aws_access_key_id=cookies;aws_secret_access_key=cookies' delimiter ',' addquotes"
17+
expected_result = "unload ('SELECT count(t1.id) AS count_1 \nFROM t1') to 'cookies' credentials 'aws_access_key_id=cookies;aws_secret_access_key=cookies' delimiter ',' addquotes allowoverwrite"
1818
insert = UnloadFromSelect(select([func.count(self.t1.c.id)]), 'cookies', 'cookies', 'cookies')
1919
self.assertEqual(expected_result, str(insert))

0 commit comments

Comments
 (0)