Processor improvements and cleanup (#9)

* helper function to get all cores
  * cleanup includes

Author: bignacio

src/NUMANode.h

@@ -1,7 +1,6 @@
 #ifndef NUMA_NODE_H
 #define NUMA_NODE_H
 
-#include "TypePolicies.h"
 #include "Core.h"
 
 #include <set>

src/Pool.h

@@ -4,13 +4,11 @@
 #include <type_traits>
 #include <vector>
 #include <array>
-#include <algorithm>
 #include <functional>
 
 #include "IndexHolder.h"
 #include "TypePolicies.h"
 #include "MutexIndexer.h"
-#include "ConcurrentIndexer.h"
 #include "PoolItem.h"
 
 namespace dxpool {

src/Processor.h

@@ -15,5 +15,10 @@ using Processor = dxpool::ProcessorUnsupported;
 #endif
 
 
+static inline auto GetAllAvailableCores() -> std::set<Core> {
+    Processor processor;
+    return processor.FindAvailableCores();
+}
+
 } // namespace dxpool
 #endif

src/ProcessorLinux.h

@@ -1,7 +1,6 @@
 #ifndef PROCESSOR_LINUX_H
 #define PROCESSOR_LINUX_H
 
-#include <thread>
 #include <pthread.h>
 #include <sched.h>
 #include <set>

src/ProcessorUnsupported.h

@@ -45,7 +45,7 @@ class ProcessorUnsupported final: public ProcessorOperator {
     *
     * @return
     */
-    auto SetThreadAffinity(const std::set<Core>& cores) const -> bool {
+    auto SetThreadAffinity(const std::set<Core>& cores) const -> bool override {
         throw PlatformUnsupportedError("not implemented for this platform");
     }
 

src/WorkerPool.h

@@ -1,7 +1,6 @@
 #ifndef WORKER_POOL_H
 #define WORKER_POOL_H
 
-#include <string>
 #include <memory>
 #include <set>
 #include <vector>

src/dxpool.h

@@ -1,3 +1,8 @@
+#ifndef DXPOOL_H
+#define DXPOOL_H
+
 #include "Pool.h"
 #include "WorkerPool.h"
-#include "Processor.h"
+#include "Processor.h"
+
+#endif //DXPOOL_H

test/ProcessorTest.cpp

@@ -75,4 +75,10 @@ TEST_CASE("Processor and NUMA nodes") { // NOLINT(cppcoreguidelines-avoid-non-co
         REQUIRE(actualAffinity == desiredAffinity);
     }
 
+
+    SECTION("Processor helper") {
+        const auto allCores = GetAllAvailableCores();
+
+        REQUIRE_FALSE(allCores.empty());
+    }
 }