wip

Author: bfabio

parser_test.go

@@ -339,7 +339,7 @@ func TestInvalidTestcasesV0_3(t *testing.T) {
 		"description_eng_screenshots_missing_file.yml": ValidationResults{
 			ValidationError{
 				"description.eng.screenshots[0]",
-				fmt.Sprintf("'no_such_file.png' is not an image: no such file : %s/no_such_file.png", cwd),
+				"'no_such_file.png' is not an image: no such file : https://raw.githubusercontent.com/italia/developers.italia.it/main/no_such_file.png",
 				20,
 				5,
 			},
@@ -369,7 +369,7 @@ func TestInvalidTestcasesV0_3(t *testing.T) {
 		"legal_authorsFile_missing_file.yml": ValidationResults{
 			ValidationError{
 				"legal.authorsFile",
-				fmt.Sprintf("'%s/no_such_authors_file.txt' does not exist", cwd),
+				"'https://raw.githubusercontent.com/italia/developers.italia.it/main/no_such_authors_file.txt' does not exist",
 				42,
 				3,
 			},

testdata/v0.3/invalid/landingURL_invalid.yml

@@ -61,10 +61,6 @@ description:
        - Will run without a problem
        - Has zero bugs
        - Solves all the problems of the world
-    screenshots:
-       - testdata/img/sshot1.png
-       - testdata/img/sshot2.png
-       - testdata/img/sshot3.png
     videos:                             # Demo videos of the software
        - https://www.youtube.com/watch?v=RaHmGbBOP84
     awards:
@@ -74,7 +70,6 @@ legal:
   license: AGPL-3.0-or-later        # SPDX expression of license
   mainCopyrightOwner: City of Chicago
   repoOwner: City of Chicago
-  authorsFile: testdata/AUTHORS              # file listing copyright information
 
 maintenance:
   type: "contract"

testdata/v0.3/invalid/landingURL_wrong_type.yml

@@ -10,7 +10,6 @@ landingURL: []
 isBasedOn: "https://github.com/italia/developers.italia.it.git"
 softwareVersion: "1.0"
 releaseDate: 2017-04-15
-logo: testdata/img/logo.png
 
 platforms:
   - android
@@ -62,20 +61,11 @@ description:
        - Will run without a problem
        - Has zero bugs
        - Solves all the problems of the world
-    screenshots:
-       - testdata/img/sshot1.png
-       - testdata/img/sshot2.png
-       - testdata/img/sshot3.png
-    videos:                             # Demo videos of the software
-       - https://www.youtube.com/watch?v=RaHmGbBOP84
-    awards:
-       - 1st Price Software of the year
 
 legal:
   license: AGPL-3.0-or-later        # SPDX expression of license
   mainCopyrightOwner: City of Chicago
   repoOwner: City of Chicago
-  authorsFile: testdata/AUTHORS              # file listing copyright information
 
 maintenance:
   type: "contract"

v0.go

@@ -118,7 +118,7 @@ type DependencyV0 struct {
 // the two-letter lowercase ISO 3166-1 alpha-2 country code.
 
 type ITSectionV0 struct {
-	CountryExtensionVersion string `yaml:"countryExtensionVersion" validate:"eq=1.0"`
+	CountryExtensionVersion string `yaml:"countryExtensionVersion"`
 
 	Conforme struct {
 		LineeGuidaDesign        bool `yaml:"lineeGuidaDesign,omitempty"`

validations.go

@@ -67,7 +67,7 @@ func getHeaderFromDomain(domain Domain, url string) map[string]string {
 func (p *Parser) isReachable(u url.URL, network bool) (bool, error) {
 	// Don't check if the network checks are disabled or if we are running in WASM
 	// because we'd most likely fail due to CORS errors.
-	if network || runtime.GOARCH == "wasm" {
+	if !network || runtime.GOARCH == "wasm" {
 		return true, nil
 	}
 
@@ -101,7 +101,7 @@ func toCodeHostingURL(file string, baseURL *url.URL) url.URL {
 		return *uri
 	}
 
-	// p.baseURL can be nil if we didn't autodetect it because
+	// baseURL can be nil if we didn't autodetect it because
 	// of DisableNetwork == true.
 	if (baseURL != nil) {
 		// If file is a relative path, let's just append it to our baseURL