-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Docs] Improve docgen accessibility #1958
Comments
If we don't find an external tool that fits what we want to have, maybe it makes sense for us to have a binary spitting markdown/html ourselves (maybe as part of |
lua-doc-extractor could be expanded to do full doc generation, but in theory we should be able to do generation from the lua library files in a way that is tool agnostic. A full, language aware parser and generator is not something we should have to maintain. Moving to https://github.com/CppCXY/emmylua-analyzer-rust/tree/main/crates/emmylua_doc_cli should be the first test. See discussion here: LuaLS/lua-language-server#3054 I'm not sure if it supports type linking, but I think we could upstream that feature, or potentially add it to a custom template for its generator. |
#1983 has added emmylua_doc_cli as the generator.
Fields are now shown, but field descriptions are lacking until rhys-vdw/lua-doc-extractor#9 is closed.
It still lacks type linking (and it doesn't support Some upstream work will need to be done to get support for this as the doc generator does not add this information into the template at all. However the doc generator is, in general, pretty nice and the code is very clean. The maintainer is open to PRs. Shouldn't be too hard to add this in ourselves.
I think this is better now. I can't find a specific example. Unfortunately there are instances where the aliased unions are not fully expanded (which would be fine if we had a type link or hover). I think it would be useful to maintain a list of specific docs that have issues so we can start to tackle them one-by-one. |
I'm aggregating on this issue a few standing issues regarding the current generated documentation:
UnitState
it should link to theUnitState
definition.Platform
orEngine
a|b|c...
without offering a way to expand to their whole definitionThis can be separated in other issues, but for now it's a reference we can work on.
The text was updated successfully, but these errors were encountered: