Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move bower and bower-installer to devDependencies #15

Open
nkoder opened this issue May 27, 2016 · 8 comments
Open

Move bower and bower-installer to devDependencies #15

nkoder opened this issue May 27, 2016 · 8 comments

Comments

@nkoder
Copy link

nkoder commented May 27, 2016

I've just noticed that in my project (which uses karma-jasmine-jquery) I get warning during npm install. This warning is about bower-installer not installed globally. And it comes as dependency of karma-jasmine-jquery.

Dev dependencies like bower shoudln't go into dependencies section of package.json to not pollute other projects which are using karma-jasmine-jquery. They should go into devDependencies section.

@JenniferSpry
Copy link

+1

1 similar comment
@mbritton
Copy link

+1

@mhart
Copy link

mhart commented Jul 25, 2016

Yeah... this actually makes karma-jasmine-jquery an 80MB dependency!!!

@ijabit
Copy link

ijabit commented Oct 20, 2016

Yes, and having the git:// protocol used in a dependency blocks installation in our corporate network. The firewall only allows port 443 and 80 outbound to Github!

@ashawley
Copy link

A security tool that audits our package.json complains about vulnerabilities in dependencies.
It's complaining about the old dependencies in karma-jasmine-jquery that are being brought in from bower. For example, handlebars 2.0.0 has this vulnerability, CVE-2015-8861.

$ npm ls handlebars
[email protected]
└─┬ [email protected] (git+https://github.com/bessdsv/bower-installer.git#7f9cece1e6fada50f44dc0851e1d85815cd1b4a7)
  └─┬ [email protected]
    └── [email protected] 

Could you merge #16 and make a release if possible?

@insetavijit
Copy link

yes , same issue as @ashawley .
do some update stuff . man

@nemoDreamer
Copy link

Any movement on this, @bessdsv ? That version of bower has been a critical security issue for a long time now, and there's no need to have it as a dependency.

@angezid
Copy link

angezid commented Feb 22, 2023

I solved bower dependency by uninstalling karma-jasmine-jquery package (it uninstalled bower and all its dependencies) and installed @metahub/karma-jasmine-jquery.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants