Skip to content

Commit e389a08

Browse files
author
benni-tec
committed
replaced custom rect in favor of Rectangle from dart:math
1 parent c37b7cf commit e389a08

File tree

10 files changed

+14
-35
lines changed

10 files changed

+14
-35
lines changed

packages/tiled/lib/src/common/color.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import 'package:color_models/color_models.dart';
1+
part of tiled;
22

33
const _mask = 0xff;
44
int _sub(int hex, int index) => (hex & (_mask << index * 8)) >> index * 8;

packages/tiled/lib/src/common/rect.dart

Lines changed: 0 additions & 17 deletions
This file was deleted.

packages/tiled/lib/src/tileset/tile.dart

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ class Tile {
2727
List<int?> terrain;
2828

2929
TiledImage? image;
30-
Rect? imageRect;
30+
Rectangle? imageRect;
3131
Layer? objectGroup;
3232
List<Frame> animation;
3333
CustomProperties properties;
@@ -66,7 +66,7 @@ class Tile {
6666
.toList() ??
6767
[],
6868
image: parser.getSingleChildOrNullAs('image', TiledImage.parse),
69-
imageRect: Rect.fromLTWH(
69+
imageRect: Rectangle(
7070
parser.getDoubleOrNull('x') ?? 0,
7171
parser.getDoubleOrNull('y') ?? 0,
7272
parser.getDoubleOrNull('width') ?? 0,

packages/tiled/lib/src/tileset/tileset.dart

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -230,7 +230,7 @@ class Tileset {
230230
final tiles = <Tile>[];
231231

232232
for (var i = 0; i < tileCount; ++i) {
233-
Rect? imageRect;
233+
Rectangle? imageRect;
234234

235235
if (columns != null &&
236236
columns != 0 &&
@@ -239,7 +239,7 @@ class Tileset {
239239
final x = (i % columns) * tileWidth;
240240
final y = i ~/ columns * tileHeight;
241241

242-
imageRect = Rect.fromLTWH(
242+
imageRect = Rectangle(
243243
x.toDouble(),
244244
y.toDouble(),
245245
tileWidth.toDouble(),

packages/tiled/lib/tiled.dart

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,6 @@ import 'package:archive/archive.dart';
99
import 'package:collection/collection.dart';
1010
import 'package:color_models/color_models.dart';
1111
import 'package:meta/meta.dart';
12-
import 'package:tiled/src/common/color.dart';
13-
import 'package:tiled/src/common/rect.dart';
1412
import 'package:xml/xml.dart';
1513

1614
part 'src/chunk.dart';
@@ -21,6 +19,7 @@ part 'src/common/gid.dart';
2119
part 'src/common/point.dart';
2220
part 'src/common/property.dart';
2321
part 'src/common/tiled_image.dart';
22+
part 'src/common/color.dart';
2423
part 'src/editor_setting/chunk_size.dart';
2524
part 'src/editor_setting/editor_setting.dart';
2625
part 'src/editor_setting/export.dart';

packages/tiled/pubspec.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
name: tiled
2-
version: 0.10.1
2+
version: 0.11.0
33
description: A Dart Tiled library. Parse your TMX files into useful representations. Compatible with Flame.
44
homepage: https://github.com/flame-engine/tiled.dart
55

packages/tiled/test/layer_test.dart

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
import 'dart:io';
22

33
import 'package:test/test.dart';
4-
import 'package:tiled/src/common/color.dart';
54
import 'package:tiled/tiled.dart';
65

76
void main() {

packages/tiled/test/object_group_test.dart

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
import 'dart:io';
22

33
import 'package:test/test.dart';
4-
import 'package:tiled/src/common/color.dart';
54
import 'package:tiled/tiled.dart';
65

76
void main() {

packages/tiled/test/parser_test.dart

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@ import 'dart:io';
22
import 'dart:math' show Rectangle;
33

44
import 'package:test/test.dart';
5-
import 'package:tiled/src/common/color.dart';
65
import 'package:tiled/tiled.dart';
76
import 'package:xml/xml.dart';
87

packages/tiled/test/tile_test.dart

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import 'dart:io';
2+
import 'dart:math';
23

34
import 'package:test/test.dart';
4-
import 'package:tiled/src/common/rect.dart';
55
import 'package:tiled/tiled.dart';
66
import 'package:xml/xml.dart';
77

@@ -58,8 +58,8 @@ void main() {
5858
final tile1 = tileset1.tiles.firstWhere((t) => t.localId == 0);
5959
final tile2 = tileset1.tiles.firstWhere((t) => t.localId == 1);
6060

61-
expect(tile1.imageRect, Rect.fromLTWH(64, 96, 32, 32));
62-
expect(tile2.imageRect, Rect.fromLTWH(0, 0, 20, 20));
61+
expect(tile1.imageRect, Rectangle(64, 96, 32, 32));
62+
expect(tile2.imageRect, Rectangle(0, 0, 20, 20));
6363
});
6464

6565
test(
@@ -70,10 +70,10 @@ void main() {
7070
final tile3 = tileset2.tiles.firstWhere((t) => t.localId == 129);
7171
final tile4 = tileset2.tiles.firstWhere((t) => t.localId == 11);
7272

73-
expect(tile1.imageRect, Rect.fromLTWH(112, 48, 16, 16));
74-
expect(tile2.imageRect, Rect.fromLTWH(64, 96, 16, 16));
75-
expect(tile3.imageRect, Rect.fromLTWH(160, 112, 16, 16));
76-
expect(tile4.imageRect, Rect.fromLTWH(176, 0, 16, 16));
73+
expect(tile1.imageRect, Rectangle(112, 48, 16, 16));
74+
expect(tile2.imageRect, Rectangle(64, 96, 16, 16));
75+
expect(tile3.imageRect, Rectangle(160, 112, 16, 16));
76+
expect(tile4.imageRect, Rectangle(176, 0, 16, 16));
7777
},
7878
);
7979
},

0 commit comments

Comments
 (0)