Skip to content

Commit 54badde

Browse files
author
Tim Sinaeve
committed
Resolved compiler warnings.
1 parent 48cdeb4 commit 54badde

File tree

62 files changed

+196
-268
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

62 files changed

+196
-268
lines changed

‎LogViewer.CallStack.Settings.pas

+1
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,7 @@ TCallStackSettings = class(TPersistent)
4949
published
5050
property ColumnHeadersVisible: Boolean
5151
read GetColumnHeadersVisible write SetColumnHeadersVisible;
52+
5253
end;
5354

5455
implementation

‎LogViewer.CallStack.View.pas

+1-1
Original file line numberDiff line numberDiff line change
@@ -77,8 +77,8 @@ TfrmCallStackView = class(TForm)
7777
DrawMode : TDrawMode;
7878
Selected : Boolean
7979
): Boolean;
80-
procedure SettingsChanged(Sender: TObject);
8180
procedure FTVPCallStackDoubleClick(Sender: TObject);
81+
procedure SettingsChanged(Sender: TObject);
8282

8383
public
8484
constructor Create(

‎LogViewer.ComPort.Settings.pas

+1-1
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,6 @@ interface
2828
type
2929
TComPortSettings = class(TPersistent)
3030
const
31-
//DEFAULT_BAUDRATE = 9600;
3231
DEFAULT_BAUDRATE = 115200;
3332
DEFAULT_POLLING_INTERVAL = 50;
3433

@@ -86,6 +85,7 @@ TComPortSettings = class(TPersistent)
8685

8786
property OnChanged: IEvent<TNotifyEvent>
8887
read GetOnChanged;
88+
8989
end;
9090

9191
implementation

‎LogViewer.Commands.pas

+2-1
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ interface
2828
type
2929
TLogViewerCommands = class(TInterfaceBase, ILogViewerCommands) // no refcount
3030
private
31-
FManager: ILogViewerManager;
31+
FManager : ILogViewerManager;
3232

3333
{$REGION 'property access methods'}
3434
function GetActiveView: ILogViewer;
@@ -55,6 +55,7 @@ TLogViewerCommands = class(TInterfaceBase, ILogViewerCommands) // no refcount
5555

5656
property Receiver: IChannelReceiver
5757
read GetReceiver;
58+
5859
end;
5960

6061
implementation

‎LogViewer.Dashboard.Data.pas

+1
Original file line numberDiff line numberDiff line change
@@ -57,6 +57,7 @@ TDashboardData = class
5757

5858
property Subscriber: ISubscriber
5959
read GetSubscriber write SetSubscriber;
60+
6061
end;
6162

6263
implementation

‎LogViewer.Dashboard.View.pas

+1
Original file line numberDiff line numberDiff line change
@@ -247,6 +247,7 @@ TfrmDashboard = class(TForm)
247247
destructor Destroy; override;
248248

249249
procedure Update; override;
250+
250251
end;
251252

252253
implementation

‎LogViewer.DataSet.View.dfm

-2
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,6 @@ object frmDataSetView: TfrmDataSetView
1111
Font.Height = -11
1212
Font.Name = 'Segoe UI'
1313
Font.Style = []
14-
OldCreateOrder = False
15-
PixelsPerInch = 96
1614
TextHeight = 13
1715
object dscMain: TDataSource
1816
Left = 16

‎LogViewer.DataSet.View.pas

+1
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,7 @@ TfrmDataSetView = class(TForm)
4242

4343
procedure Clear;
4444
procedure LoadFromStream(AStream: TStream);
45+
4546
end;
4647

4748
implementation

‎LogViewer.DisplayValues.Settings.ValueManager.pas

+1
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,7 @@ TDisplayValuesValueManager = class(TzCustomValueManager)
4949
const PItem : PPropItem;
5050
Items : TStrings
5151
); override;
52+
5253
end;
5354

5455
implementation

‎LogViewer.DisplayValues.Settings.View.dfm

-2
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,6 @@ object frmDisplayValuesSettings: TfrmDisplayValuesSettings
1111
Font.Height = -11
1212
Font.Name = 'Segoe UI'
1313
Font.Style = []
14-
OldCreateOrder = False
15-
PixelsPerInch = 96
1614
TextHeight = 13
1715
object splVertical: TSplitter
1816
Left = 145

‎LogViewer.DisplayValues.Settings.View.pas

+1
Original file line numberDiff line numberDiff line change
@@ -75,6 +75,7 @@ TfrmDisplayValuesSettings = class(TForm)
7575
ASettings : TDisplayValuesSettings
7676
); reintroduce;
7777
destructor Destroy; override;
78+
7879
end;
7980

8081
implementation

‎LogViewer.DisplayValues.Settings.pas

+1
Original file line numberDiff line numberDiff line change
@@ -107,6 +107,7 @@ TDisplayValuesSettings = class(TPersistent)
107107

108108
property OnChanged: IEvent<TNotifyEvent>
109109
read GetOnChanged;
110+
110111
end;
111112

112113
implementation

‎LogViewer.Events.pas

+1
Original file line numberDiff line numberDiff line change
@@ -74,6 +74,7 @@ TLogViewerEvents = class(TInterfaceBase, ILogViewerEvents) // no refcount
7474

7575
property OnShowDashboard: IEvent<TNotifyEvent>
7676
read GetOnShowDashboard;
77+
7778
end;
7879

7980
implementation

‎LogViewer.Factories.Toolbars.pas

+1-4
Original file line numberDiff line numberDiff line change
@@ -89,6 +89,7 @@ TLogViewerToolbarsFactory = class(TInterfacedObject, ILogViewerToolbarsFactory
8989

9090
property Transparant: Boolean
9191
read FTransparant write FTransparant default DEFAULT_TRANSPARANT;
92+
9293
end;
9394

9495
implementation
@@ -192,8 +193,6 @@ function TLogViewerToolbarsFactory.CreateMainToolbar(AOwner: TComponent;
192193
TB := TToolBar.Create(AOwner);
193194
ApplyDefaultProperties(TB);
194195
TB.Parent := AParent;
195-
//TB.Images := FActions.ActionList.Images;
196-
TB.ButtonWidth := 10;
197196
TB.AllowTextButtons := True;
198197
CreateToolButton(TB, 'actDashboard', tbsTextButton);
199198
CreateToolButton(TB);
@@ -225,8 +224,6 @@ function TLogViewerToolbarsFactory.CreateRightTopToolbar(AOwner: TComponent;
225224
TB := TToolBar.Create(AOwner);
226225
ApplyDefaultProperties(TB);
227226
TB.Parent := AParent;
228-
// TB.Images := FActions.ActionList.Images;
229-
TB.ButtonWidth := 10;
230227
TB.AllowTextButtons := True;
231228
CreateToolButton(TB, 'actAbout');
232229
CreateToolButton(TB);

‎LogViewer.Factories.pas

+1
Original file line numberDiff line numberDiff line change
@@ -111,6 +111,7 @@ TLogViewerFactories = class sealed
111111
AManager : ILogViewerManager;
112112
const APath : string
113113
): IChannelReceiver;
114+
114115
end;
115116

116117
implementation

‎LogViewer.Image.View.pas

+1
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,7 @@ TfrmImageView = class(TForm)
5050

5151
property Bitmap : TBitmap
5252
read GetBitmap;
53+
5354
end;
5455

5556
implementation

‎LogViewer.Interfaces.pas

+11
Original file line numberDiff line numberDiff line change
@@ -57,6 +57,7 @@ interface
5757

5858
property Settings: TComPortSettings
5959
read GetSettings;
60+
6061
end;
6162

6263
ISubscriber = interface
@@ -117,6 +118,7 @@ interface
117118

118119
property OnReceiveMessage: IEvent<TReceiveMessageEvent>
119120
read GetOnReceiveMessage;
121+
120122
end;
121123

122124
IChannelReceiver = interface
@@ -143,6 +145,7 @@ interface
143145

144146
property OnChange: IEvent<TNotifyEvent>
145147
read GetOnChange;
148+
146149
end;
147150

148151
IZmq = interface
@@ -181,6 +184,7 @@ interface
181184

182185
property ActionList: TActionList
183186
read GetActionList;
187+
184188
end;
185189

186190
ILogViewerMenus = interface
@@ -199,6 +203,7 @@ interface
199203

200204
property SubscriberPopupMenu: TPopupMenu
201205
read GetSubscriberPopupMenu;
206+
202207
end;
203208

204209
ILogViewer = interface
@@ -246,6 +251,7 @@ interface
246251

247252
property RightPanelVisible: Boolean
248253
read GetRightPanelVisible write SetRightPanelVisible;
254+
249255
end;
250256

251257
ILogViewerEvents = interface
@@ -280,6 +286,7 @@ interface
280286

281287
property OnShowDashboard: IEvent<TNotifyEvent>
282288
read GetOnShowDashboard;
289+
283290
end;
284291

285292
ILogViewerCommands = interface
@@ -293,6 +300,7 @@ interface
293300
procedure GotoFirst;
294301
procedure GotoLast;
295302
procedure SetFocusToFilter;
303+
296304
end;
297305

298306
ILogViewerManager = interface
@@ -346,6 +354,7 @@ interface
346354

347355
property ImageCollection: TImageCollection
348356
read GetImageCollection;
357+
349358
end;
350359

351360
ILogViewerToolbarsFactory = interface
@@ -359,6 +368,7 @@ interface
359368
AOwner : TComponent;
360369
AParent : TWinControl
361370
): TToolbar;
371+
362372
end;
363373

364374
{ Interface supported by subscribers that allow custom topics to subscribe to.
@@ -378,6 +388,7 @@ interface
378388

379389
property LogMessageLevels: TLogMessageLevels
380390
read GetLogMessageLevels write SetLogMessageLevels;
391+
381392
end;
382393

383394
implementation

‎LogViewer.LogLevels.Settings.View.dfm

+1-1
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ object frmLogLevelSettings: TfrmLogLevelSettings
2828
Align = alClient
2929
BevelOuter = bvNone
3030
TabOrder = 0
31-
ExplicitWidth = 231
31+
ExplicitWidth = 293
3232
ExplicitHeight = 394
3333
end
3434
object pnlLeft: TPanel

‎LogViewer.LogLevels.Settings.View.pas

+1
Original file line numberDiff line numberDiff line change
@@ -71,6 +71,7 @@ TfrmLogLevelSettings = class(TForm)
7171
ASettings : TLogLevelSettings
7272
); reintroduce;
7373
destructor Destroy; override;
74+
7475
end;
7576

7677
implementation

‎LogViewer.LogLevels.Settings.pas

+2
Original file line numberDiff line numberDiff line change
@@ -73,6 +73,7 @@ TLogLevelProperties = class(TPersistent)
7373

7474
property Level: TLogMessageLevel
7575
read GetLevel write SetLevel;
76+
7677
end;
7778

7879
TLogLevelSettings = class(TPersistent)
@@ -93,6 +94,7 @@ TLogLevelSettings = class(TPersistent)
9394

9495
property LogLevels: IList<TLogLevelProperties>
9596
read FLogLevels;
97+
9698
end;
9799

98100
implementation

‎LogViewer.MainForm.pas

+3-1
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,9 @@
1818

1919
{ Application main form. }
2020

21-
{ Check Windows Defender firewall rules if no messages can be captured. }
21+
{ REMARKS
22+
- Check Windows Defender firewall rules if no messages can be captured.
23+
}
2224

2325
interface
2426

‎LogViewer.Manager.pas

+1
Original file line numberDiff line numberDiff line change
@@ -284,6 +284,7 @@ TdmManager = class(TDataModule, ILogViewerActions,
284284

285285
procedure AfterConstruction; override;
286286
destructor Destroy; override;
287+
287288
end;
288289

289290
implementation

‎LogViewer.MessageData.View.dfm

+12-23
Original file line numberDiff line numberDiff line change
@@ -1,30 +1,21 @@
11
object frmMessageDataView: TfrmMessageDataView
22
Left = 0
33
Top = 0
4-
Margins.Left = 5
5-
Margins.Top = 5
6-
Margins.Right = 5
7-
Margins.Bottom = 5
8-
ClientHeight = 431
9-
ClientWidth = 911
4+
ClientHeight = 287
5+
ClientWidth = 603
106
Color = clBtnFace
117
DoubleBuffered = True
128
Font.Charset = ANSI_CHARSET
139
Font.Color = clWindowText
14-
Font.Height = -17
10+
Font.Height = -11
1511
Font.Name = 'Segoe UI'
1612
Font.Style = []
17-
PixelsPerInch = 144
18-
TextHeight = 23
13+
TextHeight = 13
1914
object pnlMain: TOMultiPanel
2015
Left = 0
2116
Top = 0
22-
Width = 911
23-
Height = 431
24-
Margins.Left = 5
25-
Margins.Top = 5
26-
Margins.Right = 5
27-
Margins.Bottom = 5
17+
Width = 603
18+
Height = 287
2819
PanelCollection = <
2920
item
3021
Control = pnlLeft
@@ -35,18 +26,16 @@ object frmMessageDataView: TfrmMessageDataView
3526
MinPosition = 0.020000000000000000
3627
Align = alClient
3728
TabOrder = 0
29+
ExplicitWidth = 597
30+
ExplicitHeight = 270
3831
DesignSize = (
39-
911
40-
431)
32+
603
33+
287)
4134
object pnlLeft: TPanel
4235
Left = 0
4336
Top = 0
44-
Width = 911
45-
Height = 431
46-
Margins.Left = 5
47-
Margins.Top = 5
48-
Margins.Right = 5
49-
Margins.Bottom = 5
37+
Width = 603
38+
Height = 287
5039
Anchors = []
5140
BevelOuter = bvNone
5241
TabOrder = 0

‎LogViewer.MessageData.View.pas

+1
Original file line numberDiff line numberDiff line change
@@ -90,6 +90,7 @@ TfrmMessageDataView = class(TForm)
9090

9191
property Data: IDynamicRecord
9292
read GetData;
93+
9394
end;
9495

9596
implementation

‎LogViewer.MessageFilter.Data.pas

+1
Original file line numberDiff line numberDiff line change
@@ -89,6 +89,7 @@ TFilterData = class
8989

9090
property Color: TColor
9191
read GetColor write SetColor;
92+
9293
end;
9394

9495
implementation

0 commit comments

Comments
 (0)