Skip to content

Commit b1610a1

Browse files
thomasvlswiple-rules-gardener
authored andcommitted
Mark some swift_common apis are requiring named arguments.
RELNOTES: None. PiperOrigin-RevId: 322796362
1 parent a402116 commit b1610a1

File tree

3 files changed

+7
-1
lines changed

3 files changed

+7
-1
lines changed

swift/internal/compiling.bzl

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -978,6 +978,7 @@ def derive_module_name(*args):
978978
return name_part
979979

980980
def compile(
981+
*,
981982
actions,
982983
feature_configuration,
983984
module_name,
@@ -1199,6 +1200,7 @@ def compile(
11991200
)
12001201

12011202
def precompile_clang_module(
1203+
*,
12021204
actions,
12031205
cc_compilation_context,
12041206
feature_configuration,

swift/internal/features.bzl

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,7 @@ def are_all_features_enabled(feature_configuration, feature_names):
4646
def configure_features(
4747
ctx,
4848
swift_toolchain,
49+
*,
4950
requested_features = [],
5051
unsupported_features = []):
5152
"""Creates a feature configuration to be passed to Swift build APIs.

swift/internal/providers.bzl

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -225,7 +225,7 @@ provider.
225225
},
226226
)
227227

228-
def create_module(name, clang = None, swift = None):
228+
def create_module(name, *, clang = None, swift = None):
229229
"""Creates a value containing Clang/Swift module artifacts of a dependency.
230230
231231
At least one of the `clang` and `swift` arguments must not be `None`. It is
@@ -259,6 +259,7 @@ def create_module(name, clang = None, swift = None):
259259
)
260260

261261
def create_clang_module(
262+
*,
262263
compilation_context,
263264
module_map,
264265
precompiled_module = None):
@@ -288,6 +289,7 @@ def create_clang_module(
288289
)
289290

290291
def create_swift_module(
292+
*,
291293
swiftdoc,
292294
swiftmodule,
293295
defines = [],
@@ -315,6 +317,7 @@ def create_swift_module(
315317
)
316318

317319
def create_swift_info(
320+
*,
318321
module_name = None,
319322
modules = [],
320323
swift_infos = [],

0 commit comments

Comments
 (0)