Skip to content

Compile rust_doc_test binaries in an action #1431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
UebelAndre opened this issue Jul 4, 2022 · 3 comments
Open

Compile rust_doc_test binaries in an action #1431

UebelAndre opened this issue Jul 4, 2022 · 3 comments
Labels
enhancement rustdoc

Comments

@UebelAndre
Copy link
Collaborator

re: #1427 (comment)

I think it might be time to rethink the rust_doc_test rules. Right now the test compiles and performs tests as part of the test itself. Instead of doing this, the test binaries that perform doc tests should be compiled in an action and the binaries be the executable for running tests.
@UebelAndre
Copy link
Collaborator Author

rust-lang/rust#87022 is something that might enable this behavior.

@UebelAndre
Copy link
Collaborator Author

cc @scentini for awareness.

@UebelAndre UebelAndre mentioned this issue Jan 19, 2023
Merged
@UebelAndre
Copy link
Collaborator Author

Looks like some of the rfc is implemented. It might be worth revisiting this and trying to compile tests in the build action and run them in the test action. This would also cleanup a ton of code and build issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement rustdoc
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@UebelAndre