Skip to content

Commit edc8c5d

Browse files
committed
feat: Don't add strip levels for windows builds
1 parent f75d99d commit edc8c5d

File tree

2 files changed

+7
-1
lines changed

2 files changed

+7
-1
lines changed

rust/private/rustc.bzl

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -959,7 +959,8 @@ def construct_arguments(
959959
compilation_mode = get_compilation_mode_opts(ctx, toolchain)
960960
rustc_flags.add(compilation_mode.opt_level, format = "--codegen=opt-level=%s")
961961
rustc_flags.add(compilation_mode.debug_info, format = "--codegen=debuginfo=%s")
962-
rustc_flags.add(compilation_mode.strip_level, format = "--codegen=strip=%s")
962+
if toolchain.target_os != "windows":
963+
rustc_flags.add(compilation_mode.strip_level, format = "--codegen=strip=%s")
963964

964965
# For determinism to help with build distribution and such
965966
if remap_path_prefix != None:

test/unit/strip_level/strip_level_test_suite.bzl

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -68,6 +68,11 @@ def strip_level_test_suite(name):
6868
name = "bin",
6969
srcs = [":main.rs"],
7070
edition = "2021",
71+
target_compatible_with = [
72+
"@platforms//os:linux",
73+
"@platforms//os:macos",
74+
"@platforms//os:none",
75+
],
7176
)
7277

7378
_strip_level_for_dbg_test(

0 commit comments

Comments
 (0)