Remove genrules where possible (#7424)

* Use copy_file from Skylib to copy files.

* Simplified no_mockito_extensions without changing its function.

Author: odisseus

MODULE.bazel

@@ -503,6 +503,8 @@ http_archive(
 )
 
 _JARJAR_BUILD_FILE = """
+load("@bazel_skylib//rules:copy_file.bzl", "copy_file")
+
 java_binary(
     name = "jarjar_bin",
     srcs = glob(
@@ -525,11 +527,10 @@ java_import(
     jars = glob(["lib/asm-*.jar"]),
 )
 
-genrule(
+copy_file(
     name = "help",
-    srcs = ["src/main/com/tonicsystems/jarjar/help.txt"],
-    outs = ["com/tonicsystems/jarjar/help.txt"],
-    cmd = "cp $< $@",
+    src = "src/main/com/tonicsystems/jarjar/help.txt",
+    out = "com/tonicsystems/jarjar/help.txt",
 )
 """
 

aspect/BUILD

@@ -2,6 +2,7 @@
 # Description: Bazel aspect bundled with the Bazel IntelliJ plugin.
 #
 
+load("@bazel_skylib//rules:copy_file.bzl", "copy_file")
 load(":flag_hack.bzl", "define_flag_hack")
 load(":build_defs.bzl", "aspect_library", "aspect_files")
 
@@ -74,11 +75,11 @@ aspect_library(
 # BUILD file bundled with the aspect must not override the BUILD file
 # used for development. So we name it BUILD.aspect, and rename prior
 # to bundling with the plugin.
-genrule(
+
+copy_file(
     name = "rename_files",
-    srcs = ["BUILD.aspect"],
-    outs = ["BUILD.bazel"],
-    cmd = "cp $< $@",
+    src = "BUILD.aspect",
+    out = "BUILD.bazel",
 )
 
 _dev_aspect_path = package_name()

aspect/testing/rules/intellij_aspect_test_fixture.bzl

@@ -1,5 +1,6 @@
 """Rules for writing tests for the IntelliJ aspect."""
 
+load("@bazel_skylib//rules:copy_file.bzl", "copy_file")
 load(
     "//aspect:intellij_info.bzl",
     "intellij_info_aspect",
@@ -76,9 +77,8 @@ def intellij_aspect_test_fixture(name, deps, transitive_configs = []):
 
 def test_sources(outs):
     for out in outs:
-        native.genrule(
+        copy_file(
             name = out + ".genrule",
-            srcs = [out + ".testdata"],
-            outs = [out],
-            cmd = "cp $< $@",
+            src = out + ".testdata",
+            out = out,
         )

aswb/testdata/projects/src_transform/BUILD

@@ -1,3 +1,4 @@
+load("@bazel_skylib//rules:copy_file.bzl", "copy_file")
 load(
     "//aswb/testdata/projects:test_projects.bzl",
     "test_project_package",
@@ -26,10 +27,9 @@ java_library(
     ],
 )
 
-genrule(
+copy_file(
     name = "transformed_source",
-    srcs = ["java/com/example/TestClass.java"],
-    outs = ["gen/com/example/TestClass.java"],
-    cmd = "cp $< $@",
+    src = "java/com/example/TestClass.java",
+    out = "gen/com/example/TestClass.java",
     tags = ["ij-ignore-source-transform"],
 )

intellij_platform_sdk/build_defs.bzl

@@ -368,11 +368,9 @@ def no_mockito_extensions(name, jars, **kwargs):
             srcs = [input_jar],
             outs = [output_jar],
             cmd = """
-            cp "$<" "$@"
-            chmod u+w "$@"
             tmpdir=$$(mktemp -d)
             zipper="$$(pwd)/$(execpath @bazel_tools//tools/zip:zipper)"
-            "$$zipper" x "$@" -d ".out"
+            "$$zipper" x "$<" -d ".out"
             mv ".out" "$$tmpdir"
 
             pushd "$$tmpdir/.out" >/dev/null