Skip to content

cc_wrapper.sh.tpl has comment referring to old approach that has long been replaced #476

@Pagten

Description

@Pagten

I happened to be reading the cc_wrapper.sh.tpl file, which has the following comment at the top:

# OS X relpath is not really working. This is a wrapper script around gcc
# to simulate relpath behavior.
#
# This wrapper uses install_name_tool to replace all paths in the binary
# (bazel-out/.../path/to/original/library.so) by the paths relative to
# the binary. It parses the command line to behave as rpath is supposed
# to work.
#
# See https://blogs.oracle.com/dipol/entry/dynamic_libraries_rpath_and_mac
# on how to set those paths for Mach-O binaries.

This comment appears to be referring to the solution implemented in the initial version of cc_wrapper.sh.tpl in this commit. That solution was completely replaced with a different approach in this commit, however. The comment still refers to the old approach, which can be confusing when trying to understand what the wrapper script is doing.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions