Skip to content

Transfer rules_scala to bazel-contrib #1616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
4 tasks done
meteorcloudy opened this issue Sep 17, 2024 · 21 comments
Closed
4 tasks done

Transfer rules_scala to bazel-contrib #1616

meteorcloudy opened this issue Sep 17, 2024 · 21 comments

Comments

@meteorcloudy
Copy link

meteorcloudy commented Sep 17, 2024 •
edited
Loading

Description:

This issue proposes transferring the rules_scala repository from the bazelbuild GitHub organization to the bazel-contrib GitHub organization, which is owned by the Community for Bazel project under the Linux Foundation.

GitHub Discussion: https://github.com/orgs/bazelbuild/discussions/2

Impacts:

  • GitHub issues & PRs will be transferred to the new repository.
  • Branch protection rules will need to be transferred to the new repository.
  • Individual maintainers will be transferred to the new repository.
  • GitHub teams will NOT be transferred to the new repository and will need to be re-created.
  • Bazel CI configurations will need to be updated to point to the new repository.

Read more on Transferring a repository from GitHub documentation.

Checklist:

  • Obtain approval from the current project maintainers (@liucijus, @simuons).
  • Obtain approval from the bazel-contrib SIG (@alexeagle).
  • Initiate the transfer process on GitHub (@meteorcloudy).
  • Update Bazel CI settings and confirm presubmit & postsubmit work (@meteorcloudy).
@alexeagle
Copy link

Notes from SIG meeting: this transfer was unanimously approved by a thumbs-up vote.

@simuons
Copy link
Collaborator

simuons commented Sep 17, 2024

Approve. Thanks.

@liucijus
Copy link
Collaborator

👍🏻

@meteorcloudy
Copy link
Author

Thanks for the approvals, I'll initiate the transfer now.

@meteorcloudy
Copy link
Author

Just noticed rules_scala doesn't support Bzlmod yet, is that going to be a blocker? @alexeagle

See 9 from https://bazel-contrib.github.io/SIG-rules-authors/hosting-policy.html#adding-criteria

@alexeagle
Copy link

Yes, thank you - we ought to hold off on this one in that case.

Of course it's just as feasible to fix for bzlmod after the transfer, but I think the SIG would like to know who is committed to doing that work.

@meteorcloudy
Copy link
Author

Agree, it's better to clarify that since we are disabling WORKSPACE in Bazel 8.

@meteorcloudy
Copy link
Author

Essentially blocking on #1595

@liucijus @simuons Any plan to review and accept that PR?

@simuons
Copy link
Collaborator

simuons commented Sep 25, 2024

@meteorcloudy I don't think that PR is complete. I'll be able to look at this next week.

@mbland
Copy link
Contributor

mbland commented Oct 2, 2024

BTW, I've just posted my willingness to contribute to Bzlmodification in #1482 (comment), if folks are cool with that. As stated there, I've a (mostly) working branch already.

@simuons
Copy link
Collaborator

simuons commented Oct 8, 2024

Hi, @mbland, if you could take this that would be awesome. I promised to look at it a week ago but couldn't. So any help here would be greatly appreciated.

@mbland
Copy link
Contributor

mbland commented Oct 8, 2024

@simuons My pleasure! I'm very close to having the bzlmod branch in my fork passing ./test_all.sh. I'll be carving off other independent pieces shortly.

A question regarding Bazel 6 support: I'm making sure my changes are still compatible with Bazel 6 and WORKSPACE, but I've also got them working with the latest Bazel 7. I don't have a strong opinion, but I'm curious which of the following options sound good to you:

  • Keep .bazelversion and .bazelci at 6.5.0, test Bazel 7 locally while developing.
  • Bump .bazelversion and .bazelci to (currently) 7.3.2, test Bazel 6 locally while developing.
  • Bump .bazelversion to 6.5.0 and add extra CI jobs for 7.3.2 (or vice versa).

@mbland
Copy link
Contributor

mbland commented Oct 11, 2024

FYI, a brief status update: #1482 (comment)

Basically, I'm very close to being done with my first draft, and anticipate sending more pull requests soon.

@meteorcloudy
Copy link
Author

/cc @romanowski, @lukaszwawrzyk from VirtusLab, who are also very interested in helping rules_scala development.

@simuons
Copy link
Collaborator

simuons commented Oct 18, 2024

Hi, @mbland, answering "regarding Bazel 6 support: ". I think we should use third option. Keep bazel 6 until bzlmod is supported. Once bzlmod is ready we will make bazel 6 release and switch to bazel 7. Does this sound good to you?

@mbland
Copy link
Contributor

mbland commented Oct 18, 2024

@simuons Sounds good to me!

@meteorcloudy
Copy link
Author

meteorcloudy commented Apr 1, 2025 •
edited
Loading

Thanks to @mbland #1482 is close to the finish line. I think bazel-contrib can accept the transfer now and it will make the publish to bcr process easier (a fixed releaser isn't necessary anymore).

@alexeagle @simuons @liucijus Please confirm if you are fine with the transfer.

@mbland mbland mentioned this issue Apr 1, 2025
Merged
@meteorcloudy
Copy link
Author

Gently ping~ @simuons @liucijus

@mbland mbland mentioned this issue Apr 29, 2025
Merged
@meteorcloudy
Copy link
Author

@simuons @liucijus Since this has been previously approved, I'll start with the transfer process tomorrow so that publishing rules_scala to BCR is easier.

mbland added a commit to mbland/rules_scala that referenced this issue Apr 29, 2025
@mbland
Set bazel-contrib registry_fork in publish-to-bcr
4c4fcaf 
@meteorcloudy confirmed the transfer of the repo to the bazel-contrib
org in bazelbuild#1616. Transfering ownership before publishing the release will
streamline publishing to the Bazel Central Registry by avoiding the need
for a personal bazel-central-registry fork.
mbland added a commit to mbland/rules_scala that referenced this issue Apr 29, 2025
@mbland
Set bazel-contrib registry_fork in publish-to-bcr
c71eaa7 
@meteorcloudy confirmed the transfer of the repo to the bazel-contrib
org in bazel-contrib#1616. Transfering ownership before publishing the release will
streamline publishing to the Bazel Central Registry by avoiding the need
for a personal bazel-central-registry fork.
@meteorcloudy
Copy link
Author

I'm starting the transfer process now.

@meteorcloudy
Copy link
Author

This is done, let me know if there is any issues.

alexeagle pushed a commit that referenced this issue May 1, 2025
@mbland
Use the Publish to BCR reusable GitHub workflow (#1731)
e2575a3 
* Use the Publish to BCR reusable GitHub workflow

Updates `.github/workflows/release.yml` and adds `publish-to-bcr.yml`
for publishing to the Bazel Central Registry. Part of #1482 (originally
broken out from #1722).

`release.yml` now uses the `release_ruleset` workflow from
`bazel-contrib/.github`, which does everything `release.yml` did
previously and adds SLSA provenance attestations. `release.yml` then
invokes the new `publish-to-bcr.yml` workflow after publishing a
successful release to GitHub.

Requires that the `BCR_PUBLISH_TOKEN` GitHub secret and the
`registry_fork` specified in `.github/workflows/publish-to-bcr.yml` are
in place.

See `.bcr/README.md` for all the details and references.

---

This will enable automated publishing to https://registry.bazel.build/.

* Bump to bazel-contrib/publish-to-bcr v0.1.0

Suggested by @kormide in #1731.

* Bump bazel-contrib/.github release_ruleset v7.2.2

Recommended by @kormide based on my question in #1731.

* Set bazel-contrib registry_fork in publish-to-bcr

@meteorcloudy confirmed the transfer of the repo to the bazel-contrib
org in #1616. Transfering ownership before publishing the release will
streamline publishing to the Bazel Central Registry by avoiding the need
for a personal bazel-central-registry fork.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@alexeagle @mbland @simuons @liucijus @meteorcloudy