Skip to content

Commit 5dc029a

Browse files
committed
cleanup, docs
1 parent 89fd1b9 commit 5dc029a

File tree

2 files changed

+5
-2
lines changed

2 files changed

+5
-2
lines changed

python/pip_install/pip_repository.bzl

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -800,7 +800,10 @@ def _whl_library_impl(rctx):
800800
parsed_whl = parse_whl_name(whl_path.basename)
801801
if parsed_whl.platform_tag != "any" and parsed_whl.abi_tag not in ["abi3", "none"]:
802802
# NOTE @aignas 2023-12-04: if the wheel is a platform specific
803-
# wheel, we only include deps for that target platform
803+
# wheel, we only include deps for that target platform, however
804+
# we do this only if the abi is cp3Y, because otherwise we may to
805+
# be able to use the same wheel and generate deps for multiple Python
806+
# versions.
804807
target_platforms = [
805808
"{}_{}_{}".format(parsed_whl.abi_tag, p.os, p.cpu)
806809
for p in whl_target_platforms(parsed_whl.platform_tag)

python/private/bzlmod/pip.bzl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -197,7 +197,7 @@ def _create_whl_repos(*, module_ctx, pip_attr, whl_map, whl_overrides, config_se
197197

198198
target_platforms = [
199199
"cp{}_{}_{}".format(
200-
version_label(pip_attr.python_version),
200+
version_label(major_minor),
201201
platforms[0].os,
202202
platforms[0].cpu,
203203
),

0 commit comments

Comments
 (0)