Skip to content

Commit 47a78d7

Browse files
committed
make empty requirements file work
1 parent de5f2b8 commit 47a78d7

File tree

3 files changed

+12
-2
lines changed

3 files changed

+12
-2
lines changed

python/private/pip_config_settings.bzl

+1-1
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,7 @@ _flags = struct(
9090

9191
def pip_config_settings(
9292
*,
93-
python_versions,
93+
python_versions = [],
9494
glibc_versions = [],
9595
muslc_versions = [],
9696
osx_versions = [],

python/private/render_pkg_aliases.bzl

+1-1
Original file line numberDiff line numberDiff line change
@@ -399,7 +399,7 @@ def multiplatform_whl_aliases(*, aliases, default_version, **kwargs):
399399
ret.extend(versioned.values())
400400
return ret
401401

402-
def _render_pip_config_settings(python_versions, target_platforms = [], osx_versions = [], glibc_versions = [], muslc_versions = []):
402+
def _render_pip_config_settings(python_versions = [], target_platforms = [], osx_versions = [], glibc_versions = [], muslc_versions = []):
403403
return """\
404404
load("@rules_python//python/private:pip_config_settings.bzl", "pip_config_settings")
405405

tests/pip_hub_repository/render_pkg_aliases/render_pkg_aliases_test.bzl

+10
Original file line numberDiff line numberDiff line change
@@ -438,6 +438,15 @@ def _test_aliases_with_groups(env):
438438

439439
_tests.append(_test_aliases_with_groups)
440440

441+
def _test_empty_flag_versions(env):
442+
got = get_whl_flag_versions(
443+
aliases = [],
444+
)
445+
want = {}
446+
env.expect.that_dict(got).contains_exactly(want)
447+
448+
_tests.append(_test_empty_flag_versions)
449+
441450
def _test_get_python_versions(env):
442451
got = get_whl_flag_versions(
443452
aliases = [
@@ -758,6 +767,7 @@ def _test_cp37_abi3_manylinux_2_17_musllinux_1_1_aarch64(env):
758767
_tests.append(_test_cp37_abi3_manylinux_2_17_musllinux_1_1_aarch64)
759768

760769
def _test_multiplatform_whl_aliases_empty(env):
770+
# Check that we still work with an empty requirements.txt
761771
got = multiplatform_whl_aliases(aliases = [], default_version = None)
762772
env.expect.that_collection(got).contains_exactly([])
763773

0 commit comments

Comments
 (0)