Skip to content

[tracking] rollup_bundle API refactoring #826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
1 of 11 tasks
alexeagle opened this issue Jun 5, 2019 · 2 comments
Closed
1 of 11 tasks

[tracking] rollup_bundle API refactoring #826

alexeagle opened this issue Jun 5, 2019 · 2 comments
Labels
cleanup Tech debt, resolving it improves our own velocity
Milestone
1.0

Comments

@alexeagle
Copy link
Collaborator

alexeagle commented Jun 5, 2019 •
edited
Loading

Should have an agreed design doc for updating rollup_bundle:

Requirements:

  • Ability to use different bundle types (es2015, umd, cjs, …)
  • Ability to use different language levels (es2015, es5)
  • Ability to use minified bundles
  • No unnecessary actions are run
  • Full sourcemap support (correctly mapping to original source)
  • Standalone @bazel/rollup npm package
  • Users don't manually specify lazy-loaded additional entry points

Nice to have / future / open for debate:

  • Custom rollup plugin support
  • Base rollup config input
  • Standalone terser rule
  • Standalone downlevel/to-es5 rule
@alexeagle alexeagle added this to the 1.0 milestone Aug 23, 2019
@gregmagolan
Copy link
Collaborator

Related:
terser runs across chunks in seria: #822
rollup_bundle loses sourcemap context due to running tsc for downleveling: #175

@alexeagle alexeagle added cleanup Tech debt, resolving it improves our own velocity package:rollup labels Sep 23, 2019
@alexeagle
Copy link
Collaborator Author

Done and released 🌮

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cleanup Tech debt, resolving it improves our own velocity
Projects
None yet
Milestone
1.0
Development

No branches or pull requests
2 participants
@alexeagle @gregmagolan