feat(rollup): provide sourcemaps for all output types

Author: Jason Bedard

internal/e2e/check.js

@@ -9,7 +9,10 @@ function read(readPath) {
       .replace(/\r\n/g, '\n')
       .replace(/\\\\/g, '/')
       // In the sourcemap, CRLF is turned into a string encoding
-      .replace(/\\r\\n/g, '\\n');
+      .replace(/\\r\\n/g, '\\n')
+      // Replace platform specific directories in paths
+      .replace(/\/\w+-fastbuild\//g, '/__platform__-fastbuild/')
+    ;
 }
 
 // These keys are arbitrary and local to this test.

internal/e2e/rollup/BUILD.bazel

@@ -25,9 +25,16 @@ jasmine_node_test(
         "*_golden.js.map",
     ]) + [
         ":bundle",
+        ":bundle.es2015.js",
+        ":bundle.es2015.js.map",
+        ":bundle.min.es2015.js",
+        ":bundle.min.es2015.js.map",
         ":bundle.cjs.js",
+        ":bundle.cjs.js.map",
         ":bundle.umd.js",
+        ":bundle.umd.js.map",
         ":bundle.min_debug.js",
+        ":bundle.min_debug.js.map",
     ],
     deps = [
         "//internal/e2e:check_lib",

internal/e2e/rollup/bundle-cjs_golden.js.map

@@ -0,0 +1,33 @@
+/**
+ * @license A dummy license banner that goes at the top of the file.
+ * This is version v1.2.3
+ */
+
+var bundle = (function (exports, some_global_var) {
+  'use strict';
+
+  const fum = 'Wonderland';
+
+  var hello = 'Hello';
+
+  const name = 'Alice';
+
+  console.log(`${hello}, ${name} in ${fum}`);
+
+  // Test for sequences = false
+  class A {
+    a() {
+      return document.a;
+    }
+  }
+  function inline_me() {
+    return 'abc';
+  }
+  console.error(new A().a(), inline_me(), some_global_var.thing);
+
+  exports.A = A;
+
+  return exports;
+
+}({}, runtime_name_of_global_var));
+//# sourceMappingURL=bundle.es2015.js.map

internal/e2e/rollup/bundle-es2015_golden.js.map

@@ -0,0 +1,5 @@
+/**
+ * @license A dummy license banner that goes at the top of the file.
+ * This is version v1.2.3
+ */
+var bundle=function(n,e){"use strict";console.log("Hello, Alice in Wonderland");class o{a(){return document.a}}return console.error((new o).a(),"abc",e.thing),n.A=o,n}({},runtime_name_of_global_var);

internal/e2e/rollup/bundle-es2015_golden.js_

@@ -5,10 +5,15 @@ describe('bundling', () => {
   it('should work', () => {
     check(path, 'bundle.min.js', 'bundle-min_golden.js_');
   });
-  it('should produce a sourcemap', () => {
+  it('should produce sourcemaps', () => {
     // TODO(alexeagle): the right assertion is to load up the source-map library
     // and assert that the sourcemap actually maps back to the sources
     check(path, 'bundle.min.js.map', 'bundle-min_golden.js.map');
+    check(path, 'bundle.min_debug.js.map', 'bundle-min-debug_golden.js.map');
+    check(path, 'bundle.min.es2015.js.map', 'bundle-min-es2015_golden.js.map');
+    check(path, 'bundle.es2015.js.map', 'bundle-es2015_golden.js.map');
+    check(path, 'bundle.cjs.js.map', 'bundle-cjs_golden.js.map');
+    check(path, 'bundle.umd.js.map', 'bundle-umd_golden.js.map');
   });
   it('should produce a debug bundle', () => {
     check(path, 'bundle.min_debug.js', 'bundle-min-debug_golden.js_');

internal/e2e/rollup/bundle-min-debug_golden.js.map

@@ -441,12 +441,25 @@ def _rollup_bundle(ctx):
         _generate_code_split_entry(ctx, ctx.label.name + "_chunks", ctx.outputs.build_umd)
         _generate_code_split_entry(ctx, ctx.label.name + "_chunks", ctx.outputs.build_cjs)
 
-        # There is no source map explorer output when code-splitting but we still need to satisfy the output
-        ctx.actions.expand_template(
-            output = ctx.outputs.explore_html,
-            template = ctx.file._no_explore_html,
-            substitutions = {},
-        )
+        # There is no source map or explorer output when code-splitting but we still need to satisfy the output
+        [
+            ctx.actions.expand_template(
+                output = output,
+                template = ctx.file._no_explore_html,
+                substitutions = {},
+            )
+            for output in [
+                ctx.outputs.explore_html,
+                ctx.outputs.build_es2015_map,
+                ctx.outputs.build_es2015_min_map,
+                ctx.outputs.build_es2015_min_debug_map,
+                ctx.outputs.build_es5_min_map,
+                ctx.outputs.build_es5_min_debug_map,
+                ctx.outputs.build_umd_map,
+                ctx.outputs.build_cjs_map,
+            ]
+        ]
+
         files = [
             ctx.outputs.build_es2015,
             ctx.outputs.build_es2015_min,
@@ -465,18 +478,31 @@ def _rollup_bundle(ctx):
     else:
         # Generate the bundles
         rollup_config = write_rollup_config(ctx)
-        run_rollup(ctx, _collect_es2015_sources(ctx), rollup_config, ctx.outputs.build_es2015)
-        run_terser(ctx, ctx.outputs.build_es2015, ctx.outputs.build_es2015_min, config_name = ctx.label.name + "es2015_min")
-        run_terser(ctx, ctx.outputs.build_es2015, ctx.outputs.build_es2015_min_debug, debug = True, config_name = ctx.label.name + "es2015_min_debug")
+
+        # es2015
+        source_map_es2015 = run_rollup(ctx, _collect_es2015_sources(ctx), rollup_config, ctx.outputs.build_es2015)
+        run_terser(ctx, ctx.outputs.build_es2015, ctx.outputs.build_es2015_min, config_name = ctx.label.name + "es2015_min", in_source_map = source_map_es2015)
+        run_terser(ctx, ctx.outputs.build_es2015, ctx.outputs.build_es2015_min_debug, debug = True, config_name = ctx.label.name + "es2015_min_debug", in_source_map = source_map_es2015)
+
+        # es5
+        # TODO: tsc should produce a source map from the build_es2015 + source_map_es2015 inputs
+        # See: https://github.com/bazelbuild/rules_nodejs/issues/175
         _run_tsc(ctx, ctx.outputs.build_es2015, ctx.outputs.build_es5)
-        source_map = run_terser(ctx, ctx.outputs.build_es5, ctx.outputs.build_es5_min)
-        run_terser(ctx, ctx.outputs.build_es5, ctx.outputs.build_es5_min_debug, debug = True)
+        source_map_min = run_terser(ctx, ctx.outputs.build_es5, ctx.outputs.build_es5_min)
+        run_terser(ctx, ctx.outputs.build_es5, ctx.outputs.build_es5_min_debug, debug = True, in_source_map = source_map_min)
+
+        # cjs
         cjs_rollup_config = write_rollup_config(ctx, filename = "_%s_cjs.rollup.conf.js", output_format = "cjs")
         run_rollup(ctx, _collect_es2015_sources(ctx), cjs_rollup_config, ctx.outputs.build_cjs)
+
+        # umd
         umd_rollup_config = write_rollup_config(ctx, filename = "_%s_umd.rollup.conf.js", output_format = "umd")
         run_rollup(ctx, _collect_es2015_sources(ctx), umd_rollup_config, ctx.outputs.build_umd)
-        run_sourcemapexplorer(ctx, ctx.outputs.build_es5_min, source_map, ctx.outputs.explore_html)
-        files = [ctx.outputs.build_es5_min, source_map]
+
+        # TODO: ?
+        run_sourcemapexplorer(ctx, ctx.outputs.build_es5_min, source_map_min, ctx.outputs.explore_html)
+
+        files = [ctx.outputs.build_es5_min, source_map_min]
 
     return DefaultInfo(files = depset(files), runfiles = ctx.runfiles(files))
 
@@ -664,13 +690,22 @@ ROLLUP_ATTRS = {
 
 ROLLUP_OUTPUTS = {
     "build_cjs": "%{name}.cjs.js",
+    "build_cjs_map": "%{name}.cjs.js.map",
     "build_es2015": "%{name}.es2015.js",
+    "build_es2015_map": "%{name}.es2015.js.map",
     "build_es2015_min": "%{name}.min.es2015.js",
     "build_es2015_min_debug": "%{name}.min_debug.es2015.js",
+    "build_es2015_min_debug_map": "%{name}.min_debug.es2015.js.map",
+    "build_es2015_min_map": "%{name}.min.es2015.js.map",
     "build_es5": "%{name}.js",
+    # Disabled due to https://github.com/bazelbuild/rules_nodejs/issues/175
+    # "build_es5_map": "%{name}.js.map",
     "build_es5_min": "%{name}.min.js",
     "build_es5_min_debug": "%{name}.min_debug.js",
+    "build_es5_min_debug_map": "%{name}.min_debug.js.map",
+    "build_es5_min_map": "%{name}.min.js.map",
     "build_umd": "%{name}.umd.js",
+    "build_umd_map": "%{name}.umd.js.map",
     "explore_html": "%{name}.explore.html",
 }