fixup! feat(rollup): provide output groupings of js+map for each bundle type

Author: Jason Bedard

internal/e2e/rollup/BUILD.bazel

@@ -18,7 +18,7 @@ rollup_bundle(
 
 jasmine_node_test(
     name = "test",
-    srcs = glob(["*.spec.js"]),
+    srcs = ["rollup.spec.js"],
     configuration_env_vars = ["UPDATE_GOLDEN"],
     data = glob([
         "*_golden.js_",
@@ -49,9 +49,9 @@ filegroup(
 )
 
 filegroup(
-    name = "bundle-outputgroups-es5_min_debug",
+    name = "bundle-outputgroups-es2015",
     srcs = [":bundle"],
-    output_group = "es5_min_debug",
+    output_group = "es2015",
 )
 
 filegroup(
@@ -60,22 +60,23 @@ filegroup(
     output_group = "es5_min",
 )
 
+filegroup(
+    name = "bundle-outputgroups-es5_min_debug",
+    srcs = [":bundle"],
+    output_group = "es5_min_debug",
+)
+
 jasmine_node_test(
     name = "test-outputgroups",
-    srcs = glob(["*.spec.js"]),
-    configuration_env_vars = ["UPDATE_GOLDEN"],
-    data = glob([
-        "*_golden.js_",
-        "*_golden.js.map",
-    ]) + [
+    srcs = ["outputgroups.spec.js"],
+    data = [
         ":bundle-outputgroups-cjs",
-        ":bundle-outputgroups-umd",
+        ":bundle-outputgroups-es2015",
         ":bundle-outputgroups-es5_min",
         ":bundle-outputgroups-es5_min_debug",
+        ":bundle-outputgroups-umd",
     ],
     deps = [
-        "//internal/e2e:check_lib",
         "@npm//jasmine",
-        "@npm//unidiff",
     ],
 )

internal/e2e/rollup/outputgroups.spec.js

@@ -0,0 +1,34 @@
+const fs = require('fs');
+const path = require('path');
+
+function checkExists(name) {
+  if (!fs.existsSync(path.join(__dirname, name))) {
+    fail(`Output ${name} does not exist.`);
+  }
+}
+
+// TODO: the right assertions are to load up the source-map library
+// and assert that the sourcemap actually maps back to the sources
+
+describe('outputgroups', () => {
+  it('should produce a es2015 sourcemap', () => {
+    checkExists('bundle.es2015.js');
+    checkExists('bundle.es2015.js.map');
+  });
+  it('should produce a es5_min sourcemap', () => {
+    checkExists('bundle.min.js');
+    checkExists('bundle.min.js.map');
+  });
+  it('should produce a es5_min_debug sourcemap', () => {
+    checkExists('bundle.min_debug.js');
+    checkExists('bundle.min_debug.js.map');
+  });
+  it('should produce a cjs sourcemap', () => {
+    checkExists('bundle.cjs.js');
+    checkExists('bundle.cjs.js.map');
+  });
+  it('should produce a umd sourcemap', () => {
+    checkExists('bundle.umd.js');
+    checkExists('bundle.umd.js.map');
+  });
+});

internal/e2e/rollup_code_splitting/BUILD.bazel

@@ -13,7 +13,10 @@ rollup_bundle(
 
 jasmine_node_test(
     name = "test",
-    srcs = glob(["*.spec.js"]),
+    srcs = [
+        "additional_entry.spec.js",
+        "main1.spec.js",
+    ],
     data = glob([
         "*_golden.js_",
     ]) + [
@@ -33,12 +36,6 @@ filegroup(
     output_group = "es2015",
 )
 
-filegroup(
-    name = "bundle-outputgroups-es5",
-    srcs = [":bundle"],
-    output_group = "es5",
-)
-
 filegroup(
     name = "bundle-outputgroups-es5_min",
     srcs = [":bundle"],
@@ -53,18 +50,13 @@ filegroup(
 
 jasmine_node_test(
     name = "test-outputgroups",
-    srcs = glob(["*.spec.js"]),
-    data = glob([
-        "*_golden.js_",
-    ]) + [
+    srcs = ["outputgroups.spec.js"],
+    data = [
         ":bundle-outputgroups-es2015",
-        ":bundle-outputgroups-es5",
         ":bundle-outputgroups-es5_min",
         ":bundle-outputgroups-es5_min_debug",
     ],
     deps = [
-        "//internal/e2e:check_lib",
         "@npm//jasmine",
-        "@npm//unidiff",
     ],
 )

internal/e2e/rollup_code_splitting/outputgroups.spec.js

@@ -0,0 +1,35 @@
+const fs = require('fs');
+const path = require('path');
+
+function checkExists(name) {
+  if (!fs.existsSync(path.join(__dirname, name))) {
+    fail(`Output ${name} does not exist.`);
+  }
+}
+
+// TODO: the right assertions are to load up the source-map library
+// and assert that the sourcemap actually maps back to the sources
+
+describe('outputgroups', () => {
+  it('should produce a es2015 sourcemap', () => {
+    checkExists('bundle.es2015.js');
+    checkExists('bundle_chunks_es2015/additional_entry.js');
+    checkExists('bundle_chunks_es2015/additional_entry.js.map');
+    checkExists('bundle_chunks_es2015/main1.js');
+    checkExists('bundle_chunks_es2015/main1.js.map');
+  });
+  it('should produce a es5_min sourcemap', () => {
+    checkExists('bundle.min.js');
+    checkExists('bundle_chunks_min/additional_entry.js');
+    checkExists('bundle_chunks_min/additional_entry.js.map');
+    checkExists('bundle_chunks_min/main1.js');
+    checkExists('bundle_chunks_min/main1.js.map');
+  });
+  it('should produce a es5_min_debug sourcemap', () => {
+    checkExists('bundle.min_debug.js');
+    checkExists('bundle_chunks_min_debug/additional_entry.js');
+    checkExists('bundle_chunks_min_debug/additional_entry.js.map');
+    checkExists('bundle_chunks_min_debug/main1.js');
+    checkExists('bundle_chunks_min_debug/main1.js.map');
+  });
+});