Skip to content

Commit 24e1bcf

Browse files
authored
Remove dependencies on rules_cc (#1269)
1 parent d9367d2 commit 24e1bcf

File tree

4 files changed

+6
-12
lines changed

4 files changed

+6
-12
lines changed

MODULE.bazel

+4
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,10 @@ bazel_dep(name = "rules_python", version = "0.23.1")
1515
bazel_dep(name = "gazelle", version = "0.34.0", dev_dependency = True, repo_name = "bazel_gazelle")
1616
bazel_dep(name = "bazel_skylib_gazelle_plugin", version = "1.5.0", dev_dependency = True)
1717
bazel_dep(name = "stardoc", version = "0.5.6", dev_dependency = True, repo_name = "io_bazel_stardoc")
18+
bazel_dep(name = "bazel_ci_rules", version = "1.0.0", dev_dependency = True)
19+
20+
# note that this dev_dependency is only needed because bazel_ci_rules
21+
# depends on it. If you are not using bazel_ci_rules; ideally we'd be able to remove this.
1822
bazel_dep(name = "rules_cc", version = "0.0.9", dev_dependency = True)
1923

2024
python = use_extension("@rules_python//python/extensions:python.bzl", "python")

WORKSPACE.bzlmod

+1-10
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,6 @@
11
workspace(name = "rules_foreign_cc")
22

3-
load("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive")
4-
5-
http_archive(
6-
name = "bazelci_rules",
7-
sha256 = "eca21884e6f66a88c358e580fd67a6b148d30ab57b1680f62a96c00f9bc6a07e",
8-
strip_prefix = "bazelci_rules-1.0.0",
9-
url = "https://github.com/bazelbuild/continuous-integration/releases/download/rules-1.0.0/bazelci_rules-1.0.0.tar.gz",
10-
)
11-
12-
load("@bazelci_rules//:rbe_repo.bzl", "rbe_preconfig")
3+
load("@bazel_ci_rules//:rbe_repo.bzl", "rbe_preconfig")
134

145
# Creates a default toolchain config for RBE.
156
# Use this as is if you are using the rbe_ubuntu16_04 container,

examples/MODULE.bazel

+1
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ bazel_dep(name = "rules_swift", version = "1.6.0", repo_name = "build_bazel_rule
1717
bazel_dep(name = "rules_apple", version = "3.4.0", repo_name = "build_bazel_rules_apple")
1818
bazel_dep(name = "apple_support", version = "1.12.0", repo_name = "build_bazel_apple_support")
1919
bazel_dep(name = "rules_python", version = "0.23.0")
20+
bazel_dep(name = "rules_cc", version = "0.0.9")
2021

2122
python = use_extension("@rules_python//python/extensions:python.bzl", "python")
2223
python.toolchain(

toolchains/built_toolchains.bzl

-2
Original file line numberDiff line numberDiff line change
@@ -260,8 +260,6 @@ def _pkgconfig_toolchain(version, register_toolchains):
260260
http_archive,
261261
name = "glib_dev",
262262
build_file_content = '''
263-
load("@rules_cc//cc:defs.bzl", "cc_library")
264-
265263
cc_import(
266264
name = "glib_dev",
267265
hdrs = glob(["include/**"]),

0 commit comments

Comments
 (0)