Warnings for Lisp code point to Lisp code (#457)

* Warnings for Lisp code point to Lisp code

* fix tests

* k

Author: chrisrink10

src/basilisp/lang/compiler/generator.py

@@ -664,7 +664,8 @@ def _def_to_py_ast(  # pylint: disable=too-many-branches
     # Warn if this symbol is potentially being redefined
     if __should_warn_on_redef(ctx, defsym, safe_name, def_meta):
         logger.warning(
-            f"redefining local Python name '{safe_name}' in module '{ctx.current_ns.module.__name__}'"
+            f"redefining local Python name '{safe_name}' in module "
+            f"'{ctx.current_ns.module.__name__}' ({node.env.ns}:{node.env.line})"
         )
 
     meta_ast = gen_py_ast(ctx, node.meta)
@@ -2020,7 +2021,10 @@ def _var_sym_to_py_ast(
         )
 
     if ctx.warn_on_var_indirection:
-        logger.warning(f"could not resolve a direct link to Var '{var_name}'")
+        logger.warning(
+            f"could not resolve a direct link to Var '{var_name}' "
+            f"({node.env.ns}:{node.env.line})"
+        )
 
     return __var_find_to_py_ast(var_name, ns_name, py_var_ctx)
 

tests/basilisp/compiler_test.py

@@ -330,7 +330,7 @@ def test_warn_on_redef_if_warn_on_redef_meta_missing(
         assert (
             "basilisp.lang.compiler.generator",
             logging.WARNING,
-            f"redefining local Python name 'unique_djhvyz' in module '{ns.name}'",
+            f"redefining local Python name 'unique_djhvyz' in module '{ns.name}' (test:2)",
         ) in caplog.record_tuples
 
     def test_redef_vars(self, ns: runtime.Namespace, caplog):
@@ -343,7 +343,7 @@ def test_redef_vars(self, ns: runtime.Namespace, caplog):
         """
         )
         assert (
-            f"redefining local Python name 'orig' in module '{ns.name}'"
+            f"redefining local Python name 'orig' in module '{ns.name}' (test:2)"
         ) not in caplog.messages
 
     def test_def_dynamic(self, ns: runtime.Namespace):
@@ -3011,7 +3011,7 @@ def test_warning_for_cross_ns_reference(self, other_ns, caplog):
         assert (
             "basilisp.lang.compiler.generator",
             logging.WARNING,
-            "could not resolve a direct link to Var 'm'",
+            "could not resolve a direct link to Var 'm' (test:1)",
         ) in caplog.record_tuples
 
     def test_no_warning_for_cross_ns_reference_if_warning_disabled(
@@ -3020,21 +3020,25 @@ def test_no_warning_for_cross_ns_reference_if_warning_disabled(
         lcompile(
             "(fn [] (other.ns/m :z))", opts={compiler.WARN_ON_VAR_INDIRECTION: False}
         )
-        assert ("could not resolve a direct link to Var 'm'") not in caplog.messages
+        assert (
+            "could not resolve a direct link to Var 'm' (test:1)"
+        ) not in caplog.messages
 
     def test_warning_for_cross_ns_alias_reference(self, other_ns, caplog):
         lcompile("(fn [] (other/m :z))", opts={compiler.WARN_ON_VAR_INDIRECTION: True})
         assert (
             "basilisp.lang.compiler.generator",
             logging.WARNING,
-            "could not resolve a direct link to Var 'm'",
+            "could not resolve a direct link to Var 'm' (test:1)",
         ) in caplog.record_tuples
 
     def test_no_warning_for_cross_ns_alias_reference_if_warning_disabled(
         self, other_ns, caplog
     ):
         lcompile("(fn [] (other/m :z))", opts={compiler.WARN_ON_VAR_INDIRECTION: False})
-        assert ("could not resolve a direct link to Var 'm'") not in caplog.messages
+        assert (
+            "could not resolve a direct link to Var 'm' (test:1)"
+        ) not in caplog.messages
 
     def test_warning_on_imported_name(self, ns: runtime.Namespace, caplog):
         """Basilisp should be able to directly resolve a link to cross-namespace
@@ -3047,7 +3051,7 @@ def test_warning_on_imported_name(self, ns: runtime.Namespace, caplog):
                 opts={compiler.WARN_ON_VAR_INDIRECTION: True},
             )
             assert (
-                "could not resolve a direct link to Python variable 'string/m'"
+                "could not resolve a direct link to Python variable 'string/m' (test:1)"
             ) not in caplog.messages
 
     def test_exception_raised_for_nonexistent_imported_name(