Skip to content

Commit b0fdc57

Browse files
committed
Use -s instead of _ in Hugo partial names
This is 1) fine because none of these files translate into URIs and 2) desired becuase it'll make quick-opening files less confusing for me.
1 parent 065da0f commit b0fdc57

10 files changed

+18
-24
lines changed

CONTRIBUTING.md

-6
Original file line numberDiff line numberDiff line change
@@ -307,12 +307,6 @@ canonical_link: "https://docs.basho.com/. . ." # 2 -- OPTIONAL
307307
simpler than primary content pages; `community/${project_relative_path}`.
308308
Again, this element is entirely optional.
309309
310-
**FIXME**: Actually, this is (also) a lie. We're currently using the same
311-
old head.html partial to generate community pages <head> tags.
312-
We should build a new layout/partials/community/head.html (and
313-
maybe a layout/partials/community/common_variables.html?) to
314-
handle the stated differences.
315-
316310
317311
## Problematic Markdown (and Workarounds)
318312

layouts/_default/downloads.html

+4-4
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
be prepared for some _very_ strange formatting.
1313
1414
15-
{{ partial "common_variables.html" . }}
15+
{{ partial "common-variables.html" . }}
1616
1717
{{ $HugoNode := . }}
1818
@@ -43,14 +43,14 @@
4343

4444
<!-- NOTE: We're going to leave this commented out until we're ready to deploy
4545
to the production S3 server. -->
46-
{{/* partial "google_tag_manager.html" $HugoNode */}}
46+
{{/* partial "google-tag-manager.html" $HugoNode */}}
4747

4848

4949
{{ partial "banner.html" $HugoNode }}
5050

5151

5252
{{ $dict := (dict "node" $HugoNode "menu_title" $menu_title ) }}
53-
{{ partial "content_navigation.html" $dict }}
53+
{{ partial "content-navigation.html" $dict }}
5454

5555

5656
<div class="content-well">
@@ -59,7 +59,7 @@
5959
<article class="main-article">
6060

6161

62-
{{ partial "article_front_matter.html" $HugoNode }}
62+
{{ partial "article-front-matter.html" $HugoNode }}
6363

6464

6565

layouts/_default/single.html

+5-5
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@
3535

3636
<!-- Variable Definitions
3737
====================
38-
We start this template with the "common_variables.html" partial that will
38+
We start this template with the "common-variables.html" partial that will
3939
extract useful variables from content front matter, project descriptions, and
4040
additional data files, and expose them through the global .Scratch object. For
4141
each Template / Partial / Range entered, we can then selectively extract
@@ -46,7 +46,7 @@
4646
consistent method of querying the Hugo Node object that will not change in
4747
Partials or Ranges.
4848
49-
{{ partial "common_variables.html" . }}
49+
{{ partial "common-variables.html" . }}
5050
5151
{{ $HugoNode := . }}
5252
@@ -71,14 +71,14 @@
7171

7272
<!-- NOTE: We're going to leave this commented out until we're ready to deploy
7373
to the production S3 server. -->
74-
{{/* partial "google_tag_manager.html" $HugoNode */}}
74+
{{/* partial "google-tag-manager.html" $HugoNode */}}
7575

7676

7777
{{ partial "banner.html" $HugoNode }}
7878

7979

8080
{{ $dict := (dict "node" $HugoNode "menu_title" $menu_title ) }}
81-
{{ partial "content_navigation.html" $dict }}
81+
{{ partial "content-navigation.html" $dict }}
8282

8383

8484

@@ -88,7 +88,7 @@
8888
<article class="main-article">
8989

9090

91-
{{ partial "article_front_matter.html" $HugoNode }}
91+
{{ partial "article-front-matter.html" $HugoNode }}
9292

9393

9494
<main>

layouts/community/single.html

+6-6
Original file line numberDiff line numberDiff line change
@@ -6,10 +6,10 @@
66
77
This template is specifically for pages in the Community, which require
88
significantly less front matter than project pages, to the point that we don't
9-
need to include the common_variables.html partial. Save the lack of dynamism,
9+
need to include the common-variables.html partial. Save the lack of dynamism,
1010
these pages will look very similar to more general project pages, and some of
11-
the variables defined in common_variables.html are required. The below
12-
definitions follow the same form as those laid out in common_variableshtml,
11+
the variables defined in common-variables.html are required. The below
12+
definitions follow the same form as those laid out in common-variables.html,
1313
there are just significantly fewer.
1414
1515
@@ -67,14 +67,14 @@
6767

6868
<!-- NOTE: We're going to leave this commented out until we're ready to deploy
6969
to the production S3 server. -->
70-
{{/* partial "google_tag_manager.html" $HugoNode */}}
70+
{{/* partial "google-tag-manager.html" $HugoNode */}}
7171

7272

7373
{{ partial "banner.html" $HugoNode }}
7474

7575

7676
{{ $dict := (dict "node" $HugoNode "menu_title" "community" ) }}
77-
{{ partial "content_navigation.html" $dict }}
77+
{{ partial "content-navigation.html" $dict }}
7878

7979

8080

@@ -84,7 +84,7 @@
8484
<article class="main-article">
8585

8686

87-
{{ partial "article_front_matter.html" $HugoNode }}
87+
{{ partial "article-front-matter.html" $HugoNode }}
8888

8989

9090
<main>

layouts/index.html

+1-1
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@
3333

3434
<!-- NOTE: We're going to leave this commented out until we're ready to deploy
3535
to the production S3 server. -->
36-
{{/* partial "google_tag_manager.html" . */}}
36+
{{/* partial "google-tag-manager.html" . */}}
3737

3838

3939

layouts/partials/content_navigation_submenu.html renamed to layouts/partials/content-navigation-submenu.html

+1-1
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@
5959

6060
{{- if $menu_has_children }}
6161
{{ $dict := (dict "node" $HugoNode "top_menu" $menu "menu_title" $menu_title "menu_depth" $next_depth "menu_is_open" $menu_is_open) }}
62-
{{ partial "content_navigation_submenu.html" $dict }}
62+
{{ partial "content-navigation-submenu.html" $dict }}
6363
{{- end }}
6464

6565
</li>

layouts/partials/content_navigation.html renamed to layouts/partials/content-navigation.html

+1-1
Original file line numberDiff line numberDiff line change
@@ -135,7 +135,7 @@
135135

136136
{{- if $menu_has_children }}
137137
{{ $dict := (dict "node" $HugoNode "top_menu" $menu "menu_title" $menu_title "menu_depth" 1 "menu_is_open" $menu_is_open) }}
138-
{{ partial "content_navigation_submenu.html" $dict }}
138+
{{ partial "content-navigation-submenu.html" $dict }}
139139
{{- end }}
140140

141141
</li>

0 commit comments

Comments
 (0)