Where is the tag for 1.2.8?

[willdurand]

Hi, I see that a version 1.2.8 is listed on npm but I cannot find the tag here. Could you push it by chance? Thanks.

[FND]

That would have to be 4fc9daf, as that's the only commit between v1.2.7 and when I started contributing towards v2.0.0 - but I'll leave it to @andrew to confirm that.

[andrew]

I have no idea 😂

[andrew]

I’d recommend using 2.X

[willdurand]

I have no idea 😂

oh, heh.

I’d recommend using 2.X

Yep, but our test suite fails when upgrading from 1.2.8 to 2.0.0 (using the legacy API). It seem an invalid data to decode does not throw any error anymore and we get NaN instead. I am not sure though.

[andrew]

Maybe it's worth changing the title of the issue to report that bug instead?

[willdurand]

I'll report the bug once I'll have a test case, in another issue. This issue is valid though, it'd be nice to have tags for each npm release.

[FND]

Thank you, @willdurand. Perhaps this is also related to #57 (though the behavior shouldn't have changed in that regard).

[andrew]

@willdurand as I mentioned before, I don't know where to put that tag as it was a long time ago.

[FND]

@andrew: I've just checked against the contents of the npm package and I'm fairly certain that the commit I'd identified above was in fact v1.2.8 - do you mind if I create that tag retroactively?

[andrew]

@FND sure

[FND]

Done: https://github.com/andrew/base62.js/commits/v1.2.8

Hope that helps, @willdurand.