Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SENTRY] toPairSlug handle undefined token addresses with RPC issues to avoid crashing app #1639

Open
tiagofilipenunes opened this issue Jan 28, 2025 · 0 comments

Comments

@tiagofilipenunes
Copy link
Collaborator

When there are RPC issues and the pairs information cannot be fetched, an error is being thrown from ExplorerHeader -> toPairSlug when getting the base and quote token addresses: Cannot read properties of undefined (reading 'address')

Suggestion: Check if either address is undefined and return an empty pair slug so the user can get the RPC error instead of an app crash error.

URL that is failing: https://sei.carbondefi.xyz/explore/token-pair/0x059a6b0ba116c63191182a0956cf697d0d2213ec_0x3894085ef7ff0f0aedf52e2a2704928d1ec074f1

  1. Open the URL above in private browser
  2. App crashes with error similar to e is undefined.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant