Ensure default value is used even if it is an empty string (#3)

Author: bameyrick

packages/ng-lazy-translate/src/lib/translate.service.spec.ts

@@ -134,13 +134,13 @@ describe(`LazyTranslateService`, () => {
       });
 
       it(`should return the default value if no translation is found and a default value is provided`, async () => {
-        const result = firstValueFrom(service.translate('common.no-value', undefined, 'default'));
+        const result = firstValueFrom(service.translate('common.no-value', undefined, ''));
 
         await delay();
 
         httpMock.expectOne(TEST_ASSET_PATHS[`en.common`]).flush({});
 
-        expect(await result).toBe('default');
+        expect(await result).toBe('');
       });
 
       it(`the value should update when the language changes`, async () => {

packages/ng-lazy-translate/src/lib/translate.service.ts

@@ -80,7 +80,17 @@ export class LazyTranslateService {
       distinctUntilChanged((previous, next) => isEqual(previous, next)),
       concatMap(() => (isString(key) ? of(key) : NEVER)),
       mergeMap(k => from(this.getKey(k))),
-      map(result => (isNullOrUndefined(result) ? defaultValue || key || '' : result(this.flattenParams(params))))
+      map(result => {
+        if (isNullOrUndefined(result)) {
+          if (!isNullOrUndefined(defaultValue)) {
+            return defaultValue;
+          }
+
+          return key || '';
+        }
+
+        return result(this.flattenParams(params));
+      })
     );
   }