Skip to content

Conversation

@allison-li-1016
Copy link
Contributor

@allison-li-1016 allison-li-1016 commented Nov 12, 2025

Estimated time to review: small

Description of changes:

  • added CLI option for logging events
  • added an 'EVENTS' output file logging events that occur at given tick intervals
  • added logging information to cytotoxic module to track lysis events
  • edit tests to include new mocks for event logging

Discussion:

  • We can consider logging division as an event as a proxy for cell cycle durations
  • I am concerned about the events queue object getting exponentially larger if we start tracking frequent events, we should discuss clearing the queue once the events are logged

@allison-li-1016 allison-li-1016 marked this pull request as draft November 12, 2025 22:08
@allison-li-1016 allison-li-1016 marked this pull request as ready for review November 13, 2025 00:42
@allison-li-1016 allison-li-1016 requested review from a team, Jannetty, cainja, daniellevahdat, jacob-evarts, jessicasyu, kristaphommatha and pohaoc2 and removed request for a team November 13, 2025 00:42
@Jannetty
Copy link
Member

Recording that we spoke about making sure to clear the events queue object each time it writes to file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants