Drop old versions and bump php to 7.2 (#64)

Nyholm · web-flow · commit 4e1f69638df4 · 2019-12-07T15:31:56.000+01:00
* Drop old versions

* Updated readme

* Adding changelog

* CI updates
diff --git a/.travis.yml b/.travis.yml
@@ -10,8 +10,9 @@ cache:
 env:
     global:
         - TEST_COMMAND="composer test"
-        - SYMFONY_PHPUNIT_VERSION="6.3"
+        - SYMFONY_PHPUNIT_VERSION="8.5"
         - SYMFONY_PHPUNIT_DIR="$HOME/symfony-bridge/.phpunit"
+        - SYMFONY_DEPRECATIONS_HELPER="max[self]=0"
 
 branches:
     except:
@@ -23,23 +24,17 @@ matrix:
     include:
           # Minimum supported Symfony version and latest PHP version
         - php: 7.2
-          env: COMPOSER_FLAGS="--prefer-stable --prefer-lowest" SYMFONY_DEPRECATIONS_HELPER="weak" SYMFONY_PHPUNIT_VERSION="5.7"
-        - php: 5.5
-          env: COMPOSER_FLAGS="--prefer-stable --prefer-lowest" SYMFONY_DEPRECATIONS_HELPER="weak" SYMFONY_PHPUNIT_VERSION="5.7"
+          env: COMPOSER_FLAGS="--prefer-stable --prefer-lowest" SYMFONY_DEPRECATIONS_HELPER="weak"
+        - php: 7.4
+          env: COMPOSER_FLAGS="--prefer-stable --prefer-lowest" SYMFONY_DEPRECATIONS_HELPER="weak"
 
           # Test the latest stable release
-        - php: 5.5
-          env: SYMFONY_PHPUNIT_VERSION="5.7"
-        - php: 5.6
-          env: SYMFONY_PHPUNIT_VERSION="5.7"
-        - php: 7.0
-        - php: 7.1
         - php: 7.2
+        - php: 7.3
+        - php: 7.4
           env: COVERAGE=true TEST_COMMAND="composer test-ci"
 
           # Test LTS versions
-        - php: 7.2
-          env: DEPENDENCIES="dunglas/symfony-lock:^2"
         - php: 7.2
           env: DEPENDENCIES="dunglas/symfony-lock:^3"
         - php: 7.2
@@ -59,8 +54,6 @@ before_install:
     - if ! [ -v "$DEPENDENCIES" ]; then composer require --no-update ${DEPENDENCIES}; fi;
 
 install:
-    # To be removed when this issue will be resolved: https://github.com/composer/composer/issues/5355
-    - if [[ "$COMPOSER_FLAGS" == *"--prefer-lowest"* ]]; then composer update --prefer-dist --no-interaction --prefer-stable --quiet; fi
     - composer update ${COMPOSER_FLAGS} --prefer-dist --no-interaction
     - vendor/bin/simple-phpunit install
 
diff --git a/Changelog.md b/Changelog.md
@@ -1,5 +1,17 @@
 # Changelog
 
+## 2.3.0
+
+### Added
+
+- Support for Google cloud storage
+- Support for Symfony 5
+
+### Changed
+
+- Removed support for PHP < 7.2
+- Removed support Symfony < 3.4
+
 ## 2.2.0
 
 ### Fixed
diff --git a/Command/BackupCommand.php b/Command/BackupCommand.php
@@ -69,5 +69,7 @@ protected function execute(InputInterface $input, OutputInterface $output)
         }
 
         $this->manager->makeBackup()->run($input->getArgument('database'), $destinations, $input->getOption('compression'));
+
+        return 0;
     }
 }
diff --git a/README.md b/README.md
@@ -167,7 +167,7 @@ php bin/console backup-manager:restore development s3 test/backup.sql.gz -c gzip
 Requirements
 ============
 
-- PHP 5.5
+- PHP 7.2
 - MySQL support requires `mysqldump` and `mysql` command-line binaries
 - PostgreSQL support requires `pg_dump` and `psql` command-line binaries
 - Gzip support requires `gzip` and `gunzip` command-line binaries
diff --git a/Tests/Functional/BundleInitializationTest.php b/Tests/Functional/BundleInitializationTest.php
@@ -14,7 +14,7 @@ protected function getBundleClass()
         return BMBackupManagerBundle::class;
     }
 
-    protected function setUp()
+    protected function setUp(): void
     {
         $this->addCompilerPass(new PublicServicePass('|backup_manager.*|'));
         $this->addCompilerPass(new PublicServicePass('|backup_manager|'));
diff --git a/Tests/Unit/DependencyInjection/BMBackupManagerExtensionTest.php b/Tests/Unit/DependencyInjection/BMBackupManagerExtensionTest.php
@@ -12,7 +12,7 @@
  */
 class BMBackupManagerExtensionTest extends AbstractExtensionTestCase
 {
-    protected function getContainerExtensions()
+    protected function getContainerExtensions(): array
     {
         return array(
             new BMBackupManagerExtension()
diff --git a/composer.json b/composer.json
@@ -5,29 +5,33 @@
     "type": "symfony-bundle",
     "license": "MIT",
     "authors": [
+        {
+            "name": "Tobias Nyholm",
+            "email": "tobias.nyholm@gmail.com"
+        },
         {
             "name": "Luiz Henrique Gomes Palácio",
             "email": "lhpalacio@outlook.com"
         }
     ],
     "require": {
-        "php": "^5.5 || ^7.0",
+        "php": "^7.2",
         "backup-manager/backup-manager": "^1.3",
-        "nyholm/dsn": "^0.1",
-        "symfony/config": "^2.7 || ^3.1 || ^4.0 || ^5.0",
-        "symfony/console": "^2.7 || ^3.1 || ^4.0 || ^5.0",
-        "symfony/dependency-injection": "^2.7 || ^3.1 || ^4.0 || ^5.0",
-        "symfony/filesystem": "^2.7 || ^3.1 || ^4.0 || ^5.0",
-        "symfony/framework-bundle": "^2.7 || ^3.0 || ^4.0 || ^5.0",
-        "symfony/http-kernel": "^2.7 || ^3.0 || ^4.0 || ^5.0",
-        "symfony/yaml": "^2.7 || ^3.0 || ^4.0 || ^5.0"
+        "nyholm/dsn": "^1.0",
+        "symfony/config": "^3.4 || ^4.4 || ^5.0",
+        "symfony/console": "^3.4 || ^4.4 || ^5.0",
+        "symfony/dependency-injection": "^3.4 || ^4.4 || ^5.0",
+        "symfony/filesystem": "^3.4 || ^4.4 || ^5.0",
+        "symfony/framework-bundle": "^3.4 || ^4.4 || ^5.0",
+        "symfony/http-kernel": "^3.4 || ^4.4 || ^5.0",
+        "symfony/yaml": "^3.4 || ^4.4 || ^5.0"
     },
     "require-dev": {
-        "matthiasnoback/symfony-dependency-injection-test": "^1.2 || ^2.3",
-        "matthiasnoback/symfony-config-test": "^2.2 || ^3.1",
-        "nyholm/symfony-bundle-test": "^1.3.1",
-        "superbalist/flysystem-google-storage": "^6.0 || ^ 7.0",
-        "symfony/phpunit-bridge": "^3.4 || ^4.0 || ^5.0"
+        "matthiasnoback/symfony-dependency-injection-test": "^4.1",
+        "matthiasnoback/symfony-config-test": "^4.1",
+        "nyholm/symfony-bundle-test": "^1.6",
+        "superbalist/flysystem-google-storage": "^6.0 || ^7.0",
+        "symfony/phpunit-bridge": "^5.0"
     },
     "suggest": {
         "league/flysystem-aws-s3-v3": "To use AWS S3, version 3",
@@ -49,7 +53,7 @@
     },
     "extra": {
         "branch-alias": {
-            "dev-master": "2.0-dev"
+            "dev-master": "2.3-dev"
         }
     }
 }
diff --git a/phpunit.xml.dist b/phpunit.xml.dist
@@ -5,7 +5,7 @@
          convertErrorsToExceptions="true"
          convertNoticesToExceptions="true"
          convertWarningsToExceptions="true"
-         syntaxCheck="true">
+         >
     <php>
         <env name="SHELL_VERBOSITY" value="-1" />
     </php>

Original file line number	Diff line number	Diff line change
`@@ -69,5 +69,7 @@ protected function execute(InputInterface $input, OutputInterface $output)`
`69`	`69`	`}`
`70`	`70`
`71`	`71`	`$this->manager->makeBackup()->run($input->getArgument('database'), $destinations, $input->getOption('compression'));`
	`72`	`+`
	`73`	`+ return 0;`
`72`	`74`	`}`
`73`	`75`	`}`
Original file line number	Diff line number	Diff line change
`@@ -14,7 +14,7 @@ protected function getBundleClass()`
`14`	`14`	`return BMBackupManagerBundle::class;`
`15`	`15`	`}`
`16`	`16`
`17`		`- protected function setUp()`
	`17`	`+ protected function setUp(): void`
`18`	`18`	`{`
`19`	`19`	`$this->addCompilerPass(new PublicServicePass('\|backup_manager.*\|'));`
`20`	`20`	`$this->addCompilerPass(new PublicServicePass('\|backup_manager\|'));`
Original file line number	Diff line number	Diff line change
`@@ -12,7 +12,7 @@`
`12`	`12`	`*/`
`13`	`13`	`class BMBackupManagerExtensionTest extends AbstractExtensionTestCase`
`14`	`14`	`{`
`15`		`- protected function getContainerExtensions()`
	`15`	`+ protected function getContainerExtensions(): array`
`16`	`16`	`{`
`17`	`17`	`return array(`
`18`	`18`	`new BMBackupManagerExtension()`