Mypy for azure monitor distro (Azure#32954)

Author: lzchen

sdk/monitor/azure-monitor-opentelemetry-exporter/samples/traces/collector/sample_collector.py

@@ -6,6 +6,7 @@
 Telemetry is exported to application insights with the AzureMonitorTraceExporter and Zipkin with the
 OTLP Span exporter.
 """
+# mypy: disable-error-code="attr-defined"
 import os
 from opentelemetry import trace 
 

sdk/monitor/azure-monitor-opentelemetry-exporter/samples/traces/django/sample/example/views.py

@@ -1,5 +1,6 @@
 # Copyright (c) Microsoft Corporation. All rights reserved.
 # Licensed under the MIT License.
+# mypy: disable-error-code="attr-defined"
 import os
 
 from django.http import HttpResponse

sdk/monitor/azure-monitor-opentelemetry/azure/monitor/opentelemetry/_autoinstrumentation/distro.py

@@ -11,7 +11,7 @@
     OTEL_METRICS_EXPORTER,
     OTEL_TRACES_EXPORTER,
 )
-from opentelemetry.instrumentation.distro import (
+from opentelemetry.instrumentation.distro import ( # type: ignore
     BaseDistro,
 )
 from opentelemetry.sdk.environment_variables import (

sdk/monitor/azure-monitor-opentelemetry/azure/monitor/opentelemetry/_configure.py

@@ -12,7 +12,7 @@
 from opentelemetry.instrumentation.dependencies import (
     get_dist_dependency_conflicts,
 )
-from opentelemetry.instrumentation.instrumentor import (
+from opentelemetry.instrumentation.instrumentor import ( # type: ignore
     BaseInstrumentor,
 )
 from opentelemetry.metrics import set_meter_provider
@@ -119,7 +119,7 @@ def _setup_tracing(configurations: Dict[str, ConfigurationValue]):
     span_processor = BatchSpanProcessor(
         trace_exporter,
     )
-    get_tracer_provider().add_span_processor(span_processor)
+    get_tracer_provider().add_span_processor(span_processor) # type: ignore
     if _is_instrumentation_enabled(configurations, _AZURE_SDK_INSTRUMENTATION_NAME):
         settings.tracing_implementation = OpenTelemetrySpan
 
@@ -131,9 +131,9 @@ def _setup_logging(configurations: Dict[str, ConfigurationValue]):
     log_record_processor = BatchLogRecordProcessor(
         log_exporter,
     )
-    get_logger_provider().add_log_record_processor(log_record_processor)
+    get_logger_provider().add_log_record_processor(log_record_processor) # type: ignore
     handler = LoggingHandler(logger_provider=get_logger_provider())
-    logger_name = configurations[LOGGER_NAME_ARG]
+    logger_name = configurations[LOGGER_NAME_ARG] # type: ignore
     getLogger(logger_name).addHandler(handler)
 
 

sdk/monitor/azure-monitor-opentelemetry/azure/monitor/opentelemetry/_diagnostics/diagnostic_logging.py

@@ -76,16 +76,16 @@ def _initialize(cls):
                     AzureDiagnosticLogging._initialized = True
 
     @classmethod
-    def info(cls, message: str, message_id: int):
+    def info(cls, message: str, message_id: str):
         AzureDiagnosticLogging._initialize()
         _logger.info(message, extra={'msgId': message_id})
 
     @classmethod
-    def warning(cls, message: str, message_id: int):
+    def warning(cls, message: str, message_id: str):
         AzureDiagnosticLogging._initialize()
         _logger.warning(message, extra={'msgId': message_id})
 
     @classmethod
-    def error(cls, message: str, message_id: int):
+    def error(cls, message: str, message_id: str):
         AzureDiagnosticLogging._initialize()
         _logger.error(message, extra={'msgId': message_id})

sdk/monitor/azure-monitor-opentelemetry/samples/logging/simple.py renamed to sdk/monitor/azure-monitor-opentelemetry/samples/logging/basic.py

@@ -15,6 +15,7 @@
 # cSpell:disable
 
 from pathlib import Path
+from typing import List
 
 # Build paths inside the project like this: BASE_DIR / 'subdir'.
 BASE_DIR = Path(__file__).resolve().parent.parent
@@ -29,7 +30,7 @@
 # SECURITY WARNING: don't run with debug turned on in production!
 DEBUG = True
 
-ALLOWED_HOSTS = []
+ALLOWED_HOSTS: List[str] = []
 
 
 # Application definition