Skip to content

Commit 4018e92

Browse files
Avivskiedolauli
andauthored
Alerts PageCount default value 25 (Azure#27540)
Co-authored-by: Xiaogang <[email protected]>
1 parent a8ae44c commit 4018e92

File tree

4 files changed

+10
-9
lines changed

4 files changed

+10
-9
lines changed

src/AlertsManagement/AlertsManagement.Test/SessionRecords/Microsoft.Azure.Commands.AlertsManagement.Test.ScenarioTests.AlertTests/TestAlertChangeState.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"Entries": [
33
{
4-
"RequestUri": "/subscriptions/dd91de05-d791-4ceb-b6dc-988682dc7d72/providers/Microsoft.AlertsManagement/alerts?alertState=New&includeContext=false&includeEgressConfig=false&pageCount=0&timeRange=1h&api-version=2019-05-05-preview",
4+
"RequestUri": "/subscriptions/dd91de05-d791-4ceb-b6dc-988682dc7d72/providers/Microsoft.AlertsManagement/alerts?alertState=New&includeContext=false&includeEgressConfig=false&pageCount=25&timeRange=1h&api-version=2019-05-05-preview",
55
"EncodedRequestUri": "L3N1YnNjcmlwdGlvbnMvZGQ5MWRlMDUtZDc5MS00Y2ViLWI2ZGMtOTg4NjgyZGM3ZDcyL3Byb3ZpZGVycy9NaWNyb3NvZnQuQWxlcnRzTWFuYWdlbWVudC9hbGVydHM/YWxlcnRTdGF0ZT1OZXcmaW5jbHVkZUNvbnRleHQ9ZmFsc2UmaW5jbHVkZUVncmVzc0NvbmZpZz1mYWxzZSZwYWdlQ291bnQ9MCZ0aW1lUmFuZ2U9MWgmYXBpLXZlcnNpb249MjAxOS0wNS0wNS1wcmV2aWV3",
66
"RequestMethod": "GET",
77
"RequestBody": "",

src/AlertsManagement/AlertsManagement.Test/SessionRecords/Microsoft.Azure.Commands.AlertsManagement.Test.ScenarioTests.AlertTests/TestGetAlertsFilteredByParameters.json

Lines changed: 3 additions & 3 deletions
Large diffs are not rendered by default.

src/AlertsManagement/AlertsManagement/AlertCommands/GetAzureAlert.cs

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -171,12 +171,12 @@ public class GetAzureAlertCommand : AlertsManagementBaseCmdlet
171171
/// Page count
172172
/// </summary>
173173
[Parameter(Mandatory = false,
174-
ParameterSetName = AlertsListByFilterParameterSet,
175-
HelpMessage = "Number of alerts to be fetched in a page.")]
174+
ParameterSetName = AlertsListByFilterParameterSet,
175+
HelpMessage = "Number of alerts to be fetched in a page.")]
176176
[Parameter(Mandatory = false,
177-
ParameterSetName = AlertsListByTargetResourceIdFilterParameterSet,
178-
HelpMessage = "Number of alerts to be fetched in a page.")]
179-
public int PageCount { get; set; }
177+
ParameterSetName = AlertsListByTargetResourceIdFilterParameterSet,
178+
HelpMessage = "Number of alerts to be fetched in a page.")]
179+
public int PageCount { get; set; } = 25;
180180

181181
/// <summary>
182182
/// Alert property to use while sorting

src/AlertsManagement/AlertsManagement/ChangeLog.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@
1818
- Additional information about change #1
1919
-->
2020
## Upcoming Release
21+
* Bugfix of default pageCount from 0 to 25.
2122
* Introduced various new features by upgrading code generator. Please see detail [here](https://github.com/Azure/azure-powershell/blob/main/documentation/Autorest-powershell-v4-new-features.md).
2223

2324
## Version 0.6.3

0 commit comments

Comments
 (0)