|
6 | 6 |
|
7 | 7 | ## Checklist
|
8 | 8 |
|
| 9 | +- **Mandatory**: please state whether this PR targets a [**general** release](../blob/main/CONTRIBUTING.md#target-release-types) / [**public preview**](../blob/main/CONTRIBUTING.md#target-release-types) / [**private preview**]((../blob/main/CONTRIBUTING.md#target-release-types)) / [**engineering build**](../blob/main/CONTRIBUTING.md#target-release-types) of Azure PowerShell? |
| 10 | + - `{Enter your answer here}` |
9 | 11 | - [ ] Check this box to confirm: **I have read the [_Submitting Changes_](../blob/main/CONTRIBUTING.md#submitting-changes) section of [`CONTRIBUTING.md`](../blob/main/CONTRIBUTING.md) and reviewed the following information:**
|
10 | 12 |
|
11 |
| -* **SHOULD** select appropriate branch. Cmdlets from Autorest.PowerShell should go to [`generation`](https://github.com/Azure/azure-powershell/tree/generation) branch. |
12 |
| -* **SHOULD** make the title of PR clear and informative, and in the present imperative tense. |
13 | 13 | * **SHOULD** update `ChangeLog.md` file(s) appropriately
|
14 |
| - * For any service, the `ChangeLog.md` file can be found at `src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md` |
15 |
| - * A snippet outlining the change(s) made in the PR should be written under the `## Upcoming Release` header in the past tense. Add changelog in description section if PR goes into [`generation`](https://github.com/Azure/azure-powershell/tree/generation) branch. |
| 14 | + * For SDK-based development mode, update `src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md`. |
| 15 | + * A snippet outlining the change(s) made in the PR should be written under the `## Upcoming Release` header in the past tense. |
| 16 | + * For autorest-based development mode, include the changelog in the PR description. |
16 | 17 | * Should **not** change `ChangeLog.md` if no new release is required, such as fixing test case only.
|
17 |
| -* **SHOULD** have approved design review for the changes in [this repository](https://github.com/Azure/azure-powershell-cmdlet-review-pr) ([_Microsoft internal only_](../blob/main/CONTRIBUTING.md#onboarding)) with following situations |
18 |
| - * Create new module from scratch |
19 |
| - * Create new resource types which are not easy to conform to [Azure PowerShell Design Guidelines](../blob/main/documentation/development-docs/design-guidelines) |
20 |
| - * Create new resource type which name doesn't use module name as prefix |
21 |
| - * Have design question before implementation |
22 | 18 | * **SHOULD** regenerate markdown help files if there is cmdlet API change. [Instruction](../blob/main/documentation/development-docs/help-generation.md#updating-all-markdown-files-in-a-module)
|
23 | 19 | * **SHOULD** have proper test coverage for changes in pull request.
|
24 |
| -* **SHOULD NOT** introduce [breaking changes](../blob/main/documentation/breaking-changes/breaking-changes-definition.md) in Az minor release except preview version. |
25 | 20 | * **SHOULD NOT** adjust version of module manually in pull request
|
0 commit comments