Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert BPF maps to using enums #386

Closed
astoycos opened this issue Sep 6, 2022 · 4 comments · Fixed by #397
Closed

Convert BPF maps to using enums #386

astoycos opened this issue Sep 6, 2022 · 4 comments · Fixed by #397
Assignees
@astoycos

Comments

@astoycos
Copy link
Member

astoycos commented Sep 6, 2022

Following what we currenlty do for EBPF Programs convert aya's notion of bpf maps to be an Enum rather than having concrete types (HashMap, PerfEventArray etc) for every BPF map type.

Maps were initially designed like this to allow users to implement their own maps, however now since we implement most of the ebpf API it makes more sense to switch to enums and simply support it all.
@astoycos
Copy link
Member Author

astoycos commented Sep 6, 2022

@dave-tucker You can assign me here :)

@dave-tucker dave-tucker mentioned this issue Sep 21, 2022
Closed
@astoycos
Copy link
Member Author

I've started this in https://github.com/astoycos/aya/tree/refactor-map Still have some to go but I'll keep updating with status here

@astoycos
Copy link
Member Author

This is a follow up to #75

@astoycos astoycos mentioned this issue Sep 29, 2022
Merged
@astoycos
Copy link
Member Author

astoycos commented Sep 30, 2022 •
edited
Loading

Work Items

@astoycos astoycos mentioned this issue Oct 30, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@astoycos astoycos

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor map API astoycos/aya
1 participant
@astoycos