Skip to content

Commit e63de27

Browse files
fix: Pass kms_key to _upload_analysis_config when provided (#4033)
1 parent 4b8ae3f commit e63de27

File tree

2 files changed

+6
-3
lines changed

2 files changed

+6
-3
lines changed

src/sagemaker/model_monitor/clarify_model_monitoring.py

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -178,7 +178,7 @@ def _create_baselining_processor(self):
178178
baselining_processor.base_job_name = self.base_job_name
179179
return baselining_processor
180180

181-
def _upload_analysis_config(self, analysis_config, output_s3_uri, job_definition_name):
181+
def _upload_analysis_config(self, analysis_config, output_s3_uri, job_definition_name, kms_key):
182182
"""Upload analysis config to s3://<output path>/<job name>/analysis_config.json
183183
184184
Args:
@@ -187,6 +187,8 @@ def _upload_analysis_config(self, analysis_config, output_s3_uri, job_definition
187187
Default: "s3://<default_session_bucket>/<job_name>/output"
188188
job_definition_name (str): Job definition name.
189189
If not specified then a default one will be generated.
190+
kms_key( str): The ARN of the KMS key that is used to encrypt the
191+
user code file (default: None).
190192
191193
Returns:
192194
str: The S3 uri of the uploaded file(s).
@@ -202,6 +204,7 @@ def _upload_analysis_config(self, analysis_config, output_s3_uri, job_definition
202204
json.dumps(analysis_config),
203205
desired_s3_uri=s3_uri,
204206
sagemaker_session=self.sagemaker_session,
207+
kms_key=kms_key,
205208
)
206209

207210
def _build_create_job_definition_request(
@@ -323,7 +326,7 @@ def _build_create_job_definition_request(
323326
analysis_config_uri = analysis_config
324327
else:
325328
analysis_config_uri = self._upload_analysis_config(
326-
analysis_config._to_dict(), output_s3_uri, job_definition_name
329+
analysis_config._to_dict(), output_s3_uri, job_definition_name, output_kms_key
327330
)
328331
app_specification["ConfigUri"] = analysis_config_uri
329332
app_specification["ImageUri"] = image_uri

src/sagemaker/workflow/clarify_check_step.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -435,7 +435,7 @@ def _upload_monitoring_analysis_config(self) -> str:
435435
job_definition_name = name_from_base(f"{_BIAS_MONITORING_CFG_BASE_NAME}-config")
436436

437437
return self._model_monitor._upload_analysis_config(
438-
analysis_config, output_s3_uri, job_definition_name
438+
analysis_config, output_s3_uri, job_definition_name, self.clarify_check_config.kms_key
439439
)
440440

441441
def _get_s3_base_uri_for_monitoring_analysis_config(self) -> str:

0 commit comments

Comments
 (0)