Skip to content

Commit 819a980

Browse files
authored
Move version definition back to setup.py (#612)
1 parent 1c94079 commit 819a980

File tree

3 files changed

+6
-12
lines changed

3 files changed

+6
-12
lines changed

doc/conf.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@
1313
from __future__ import absolute_import
1414

1515
import os
16+
import pkg_resources
1617
import sys
1718
from datetime import datetime
1819
from unittest.mock import MagicMock
@@ -32,8 +33,8 @@ def __getattr__(cls, name):
3233
'numpy', 'scipy', 'scipy.sparse']
3334
sys.modules.update((mod_name, Mock()) for mod_name in MOCK_MODULES)
3435

35-
version = '1.18.1'
3636
project = u'sagemaker'
37+
version = pkg_resources.require(project)[0].version
3738

3839
# Add any Sphinx extension module names here, as strings. They can be extensions
3940
# coming with Sphinx (named 'sphinx.ext.*') or your custom ones.

setup.py

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -13,21 +13,12 @@
1313
from __future__ import absolute_import
1414

1515
import os
16-
import re
1716
from glob import glob
1817
import sys
1918

2019
from setuptools import setup, find_packages
2120

2221

23-
def get_version():
24-
root = os.path.dirname(__file__)
25-
version_re = re.compile(r'''__version__ = ['"]([0-9.]+((post|dev)\d+)?)['"]''')
26-
27-
init = read(os.path.join(root, 'src/sagemaker', '__init__.py'))
28-
return version_re.search(init).group(1)
29-
30-
3122
def read(fname):
3223
return open(os.path.join(os.path.dirname(__file__), fname)).read()
3324

@@ -42,7 +33,7 @@ def read(fname):
4233
required_packages.append('enum34>=1.1.6')
4334

4435
setup(name="sagemaker",
45-
version=get_version(),
36+
version='1.18.1',
4637
description="Open source library for training and deploying models on Amazon SageMaker.",
4738
packages=find_packages('src'),
4839
package_dir={'': 'src'},

src/sagemaker/__init__.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,8 @@
1212
# language governing permissions and limitations under the License.
1313
from __future__ import absolute_import
1414

15+
import pkg_resources
16+
1517
from sagemaker import estimator, parameter, tuner # noqa: F401
1618
from sagemaker.amazon.kmeans import KMeans, KMeansModel, KMeansPredictor # noqa: F401
1719
from sagemaker.amazon.pca import PCA, PCAModel, PCAPredictor # noqa: F401
@@ -39,4 +41,4 @@
3941
from sagemaker.session import s3_input # noqa: F401
4042
from sagemaker.session import get_execution_role # noqa: F401
4143

42-
__version__ = '1.18.1'
44+
__version__ = pkg_resources.require('sagemaker')[0].version

0 commit comments

Comments
 (0)