Skip to content

Commit 359e689

Browse files
author
Boquan Fang
committed
Address PR and CI concerns
* Let s2n_stuffer_read_expected_str use memcmp to avoid CBMC problem.
1 parent ac6f580 commit 359e689

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

stuffer/s2n_stuffer_text.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ int s2n_stuffer_read_expected_str(struct s2n_stuffer *stuffer, const char *expec
7272
POSIX_ENSURE(s2n_stuffer_data_available(stuffer) >= expected_length, S2N_ERR_STUFFER_OUT_OF_DATA);
7373
uint8_t *actual = stuffer->blob.data + stuffer->read_cursor;
7474
POSIX_ENSURE_REF(actual);
75-
POSIX_ENSURE(s2n_constant_time_equals(actual, (const uint8_t *) expected, expected_length), S2N_ERR_STUFFER_NOT_FOUND);
75+
POSIX_ENSURE(!memcmp(actual, expected, expected_length), S2N_ERR_STUFFER_NOT_FOUND);
7676
stuffer->read_cursor += expected_length;
7777
POSIX_POSTCONDITION(s2n_stuffer_validate(stuffer));
7878
return S2N_SUCCESS;

0 commit comments

Comments
 (0)