Skip to content

Commit 8be30f1

Browse files
authored
fix(amazonq): should send extension version instead of IDE version in telemetry (#7893)
## Problem Language server is using `initializeParams.initializationOptions?.aws?.clientInfo?.version` https://github.com/aws/language-servers/blob/main/server/aws-lsp-codewhisperer/src/shared/telemetryUtils.ts#L99-L100 However current we're passing IDE version (vscode) and use the other field as plugin version which is not used by server. ``` clientInfo: { name: getClientName(), version: version, extension: { name: 'AmazonQ-For-VSCode', version: extensionVersion, ``` ## Solution --- - Treat all work as PUBLIC. Private `feature/x` branches will not be squash-merged at release time. - Your code changes must meet the guidelines in [CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines). - License: I confirm that my contribution is made under the terms of the Apache 2.0 license.
1 parent e78478f commit 8be30f1

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

packages/amazonq/src/lsp/client.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
* SPDX-License-Identifier: Apache-2.0
44
*/
55

6-
import vscode, { version } from 'vscode'
6+
import vscode from 'vscode'
77
import * as nls from 'vscode-nls'
88
import { LanguageClient, LanguageClientOptions, RequestType, State } from 'vscode-languageclient'
99
import { InlineCompletionManager } from '../app/inline/completion'
@@ -165,7 +165,7 @@ export async function startLanguageServer(
165165
aws: {
166166
clientInfo: {
167167
name: getClientName(),
168-
version: version,
168+
version: extensionVersion,
169169
extension: {
170170
name: 'AmazonQ-For-VSCode',
171171
version: extensionVersion,

0 commit comments

Comments
 (0)