Skip to content

Commit cc87696

Browse files
Add unit tests for existing S3PostUploadSignedPolicy class and fix exception message (#3897)
* add unit tests update unit tests to add more policies * fix exception message * add dev config * update header * Update d71acec0-6d1a-4725-bbe6-3191c988be31.json
1 parent 28fd885 commit cc87696

File tree

3 files changed

+454
-3
lines changed

3 files changed

+454
-3
lines changed
Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
{
2+
"services": [
3+
{
4+
"serviceName": "S3",
5+
"type": "patch",
6+
"changeLogMessages": [
7+
"Fix GetSignedPolicyFromJson error handling exception message"
8+
]
9+
}
10+
]
11+
}

sdk/src/Services/S3/Custom/Util/_bcl/S3PostUploadSignedPolicy.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -221,11 +221,11 @@ public static S3PostUploadSignedPolicy GetSignedPolicyFromJson(string policyJson
221221

222222
// Check if required fields exist and are of the correct type
223223
if (!json.TryGetProperty(KEY_POLICY, out var policyNode) || policyNode.ValueKind != JsonValueKind.String)
224-
throw new ArgumentException(string.Format(CultureInfo.InvariantCulture, "JSON document requires '{0}' field"), KEY_POLICY);
224+
throw new ArgumentException(string.Format(CultureInfo.InvariantCulture, "JSON document requires '{0}' field", KEY_POLICY), KEY_POLICY);
225225
if (!json.TryGetProperty(KEY_SIGNATURE, out var signatureNode) || signatureNode.ValueKind != JsonValueKind.String)
226-
throw new ArgumentException(string.Format(CultureInfo.InvariantCulture, "JSON document requires '{0}' field"), KEY_SIGNATURE);
226+
throw new ArgumentException(string.Format(CultureInfo.InvariantCulture, "JSON document requires '{0}' field", KEY_SIGNATURE), KEY_SIGNATURE);
227227
if (!json.TryGetProperty(KEY_ACCESSKEY, out var accessKeyNode) || accessKeyNode.ValueKind != JsonValueKind.String)
228-
throw new ArgumentException(string.Format(CultureInfo.InvariantCulture, "JSON document requires '{0}' field"), KEY_ACCESSKEY);
228+
throw new ArgumentException(string.Format(CultureInfo.InvariantCulture, "JSON document requires '{0}' field", KEY_ACCESSKEY), KEY_ACCESSKEY);
229229

230230
return new S3PostUploadSignedPolicy
231231
{

0 commit comments

Comments
 (0)