Skip to content

Commit db1e264

Browse files
committed
Allow use of locationName on non-flattened lists
1 parent e4d72fc commit db1e264

File tree

2 files changed

+4
-17
lines changed

2 files changed

+4
-17
lines changed

lib/query/query_param_serializer.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ function serializeList(name, list, rules, fn) {
5959
name = parts.join('.');
6060
}
6161
} else {
62-
suffix = '.member' + suffix;
62+
suffix = '.' + (memberRules.name ? memberRules.name : 'member') + suffix;
6363
}
6464
serializeMember(name + suffix, v, memberRules, fn);
6565
});

test/query/query_param_serializer.spec.coffee

Lines changed: 3 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -190,19 +190,6 @@ describe 'QueryParamSerializer', ->
190190
['Person.member.3', 'c'],
191191
])
192192

193-
it 'ignores the list-member name', ->
194-
rules =
195-
Person:
196-
type: 'list'
197-
member:
198-
locationName: 'Name'
199-
params = serialize({Person:['a','b','c']}, rules)
200-
expect(params).to.eql([
201-
['Person.member.1', 'a'],
202-
['Person.member.2', 'b'],
203-
['Person.member.3', 'c'],
204-
])
205-
206193
it 'observes both list name and list member name', ->
207194
rules =
208195
People:
@@ -212,9 +199,9 @@ describe 'QueryParamSerializer', ->
212199
locationName: 'Name'
213200
params = serialize({People:['a','b','c']}, rules)
214201
expect(params).to.eql([
215-
['Person.member.1', 'a'],
216-
['Person.member.2', 'b'],
217-
['Person.member.3', 'c'],
202+
['Person.Name.1', 'a'],
203+
['Person.Name.2', 'b'],
204+
['Person.Name.3', 'c'],
218205
])
219206

220207
describe 'maps', -> # maps are hashes with user defined keys

0 commit comments

Comments
 (0)