fix: update eslint, enforce semi, apply to test dir (#2336)

Author: jstewmon

.eslintignore

@@ -0,0 +1,2 @@
+dist/*
+test/browser/**/*

.eslintrc

@@ -10,13 +10,15 @@
   "rules": {
     "quotes": [2, "single"],
     "strict": 0,
+    "eol-last": ["error", "always"],
     "curly": 0,
     "no-empty": 0,
     "no-underscore-dangle": 0,
     "new-cap": 0,
     "dot-notation": 0,
     "no-use-before-define": 0,
-    "space-after-keywords": [2, "always"],
+    "semi": [2, "always"],
+    "keyword-spacing": [2, {"before": true, "after": true}],
     "space-before-blocks": [2, "always"],
     "no-trailing-spaces": 2,
     "space-unary-ops": 0

dist-tools/client-creator.js

@@ -105,7 +105,7 @@ ClientCreator.prototype.generateClientFileSource = function generateClientFileSo
     }
     code += 'Object.defineProperty(apiLoader.services[\'' + serviceName +'\'], \'' + version + '\', {\n';
     code += tab + 'get: function get() {\n';
-    code += tab + tab + 'var model = require(\'../apis/' + versionInfo.api + '.json\');\n'
+    code += tab + tab + 'var model = require(\'../apis/' + versionInfo.api + '.json\');\n';
     if (versionInfo.hasOwnProperty('paginators')) {
         code += tab + tab + 'model.paginators = require(\'../apis/' + versionInfo.paginators + '.json\').pagination;\n';
     }
@@ -125,7 +125,7 @@ ClientCreator.prototype.generateClientFileSource = function generateClientFileSo
       code: code,
       path: path.join(clientFolderPath, serviceName + '.js'),
       service: serviceName,
-  }
+  };
 };
 
 ClientCreator.prototype.tabs = function tabs(count) {
@@ -134,7 +134,7 @@ ClientCreator.prototype.tabs = function tabs(count) {
       tab += '  ';
   }
   return tab;
-}
+};
 
 ClientCreator.prototype.generateDefinePropertySource = function generateDefinePropertySource(objName, serviceName, className) {
   var tabs = this.tabs;
@@ -211,4 +211,4 @@ ClientCreator.prototype.writeClientServices = function writeClientServices() {
   fs.writeFileSync(browserClientInfo.path, browserClientInfo.code);
 };
 
-module.exports = ClientCreator;
+module.exports = ClientCreator;

dist-tools/create-all-services.js

@@ -3,4 +3,4 @@ var ClientCreator = require('./client-creator');
 var cc = new ClientCreator();
 
 cc.writeClientServices();
-console.log('Finished updating services.');
+console.log('Finished updating services.');

dist-tools/service-collector.js

@@ -165,4 +165,4 @@ function ServiceCollector(services) {
   return serviceCode;
 }
 
-module.exports = ServiceCollector;
+module.exports = ServiceCollector;

dist-tools/webpack.config.rn-core.js

@@ -29,4 +29,4 @@ module.exports = {
             }
         ]
     }
-}
+};

dist-tools/webpack.config.rn-dep.js

@@ -28,4 +28,4 @@ module.exports = {
             }
         ]
     }
-}
+};

dist-tools/webpack.config.rn.js

@@ -31,4 +31,4 @@ module.exports = {
             }
         ]
     }
-}
+};

lib/browser.js

@@ -16,4 +16,4 @@ if (typeof self !== 'undefined') self.AWS = AWS;
  * DO NOT REMOVE
  * browser builder will strip out this line if services are supplied on the command line.
  */
-require('../clients/browser_default');
+require('../clients/browser_default');

lib/browserCryptoLib.js

@@ -34,4 +34,4 @@ module.exports = exports = {
     createSign: function() {
       throw new Error('createSign is not implemented in the browser');
     }
-  }
+  };

lib/browserHashUtils.js

@@ -62,4 +62,4 @@ function convertToBuffer(data) {
 module.exports = exports = {
     isEmptyData: isEmptyData,
     convertToBuffer: convertToBuffer,
-}
+};

lib/browserHmac.js

@@ -50,7 +50,7 @@ Hmac.prototype.digest = function (encoding) {
     }
 
     return this.outer.digest(encoding);
-}
+};
 
 function bufferFromSecret(hashCtor, secret) {
     var input = hashUtils.convertToBuffer(secret);

lib/browserSha1.js

@@ -163,4 +163,4 @@ Sha1.prototype.processBlock = function processBlock() {
     for (i = 0; i < 16; i++) {
         this.block[i] = 0;
     }
-}
+};

lib/cloudfront/signer.js

@@ -18,7 +18,7 @@ var queryEncode = function (string) {
 var signPolicy = function (policy, privateKey) {
     var sign = crypto.createSign('RSA-SHA1');
     sign.write(policy);
-    return queryEncode(sign.sign(privateKey, 'base64'))
+    return queryEncode(sign.sign(privateKey, 'base64'));
 };
 
 var signWithCannedPolicy = function (url, expires, keyPairId, privateKey) {
@@ -45,7 +45,7 @@ var signWithCustomPolicy = function (policy, keyPairId, privateKey) {
         Policy: queryEncode(base64Encode(policy)),
         'Key-Pair-Id': keyPairId,
         Signature: signPolicy(policy, privateKey)
-    }
+    };
 };
 
 var determineScheme = function (url) {

lib/credentials/chainable_temporary_credentials.js

@@ -105,7 +105,7 @@ AWS.ChainableTemporaryCredentials = AWS.util.inherit(AWS.Credentials, {
     this.expired = true;
     this.tokenCodeFn = null;
 
-    var params = AWS.util.copy(options.params) || {}
+    var params = AWS.util.copy(options.params) || {};
     if (params.RoleArn) {
       params.RoleSessionName = params.RoleSessionName || 'temporary-credentials';
     }

lib/discover_endpoint.js

@@ -20,10 +20,10 @@ function getCacheKey(request) {
     identifiers.region = service.config.region;
   }
   if (api.serviceId) {
-    identifiers.serviceId = api.serviceId
+    identifiers.serviceId = api.serviceId;
   }
   if (service.config.credentials.accessKeyId) {
-    identifiers.accessKeyId = service.config.credentials.accessKeyId
+    identifiers.accessKeyId = service.config.credentials.accessKeyId;
   }
   return identifiers;
 }
@@ -356,4 +356,4 @@ module.exports = {
   marshallCustomIdentifiers: marshallCustomIdentifiers,
   getCacheKey: getCacheKey,
   invalidateCachedEndpoint: invalidateCachedEndpoints,
-}
+};

lib/dynamodb/numberValue.js

@@ -40,4 +40,4 @@ var DynamoDBNumberValue = util.inherit({
 /**
  * @api private
  */
-module.exports = DynamoDBNumberValue;
+module.exports = DynamoDBNumberValue;

lib/empty.js

@@ -3,4 +3,4 @@
 /**
  * @api private
  */
-module.exports = {};
+module.exports = {};

lib/event-stream/alloc-buffer.js

@@ -18,4 +18,4 @@ function allocBuffer(size) {
  */
 module.exports = {
     allocBuffer: allocBuffer
-};
+};

lib/event-stream/buffered-create-event-stream.js

@@ -18,4 +18,4 @@ function createEventStream(body, parser, model) {
  */
 module.exports = {
     createEventStream: createEventStream
-};
+};

lib/event-stream/build-message.js

@@ -171,4 +171,4 @@ var UUID_PATTERN = /^[a-f0-9]{8}-[a-f0-9]{4}-[a-f0-9]{4}-[a-f0-9]{4}-[a-f0-9]{12
  */
 module.exports = {
     buildMessage: buildMessage
-};
+};

lib/event-stream/event-message-chunker-stream.js

@@ -96,7 +96,7 @@ EventMessageChunkerStream.prototype._flush = function(callback) {
     } else {
         callback();
     }
-}
+};
 
 /**
  * @param {number} size Size of the message to be allocated.
@@ -117,4 +117,4 @@ EventMessageChunkerStream.prototype.allocateMessage = function(size) {
  */
 module.exports = {
     EventMessageChunkerStream: EventMessageChunkerStream
-};
+};

lib/event-stream/event-message-chunker.js

@@ -27,4 +27,4 @@ function eventMessageChunker(buffer) {
  */
 module.exports = {
     eventMessageChunker: eventMessageChunker
-};
+};

lib/event-stream/event-message-unmarshaller-stream.js

@@ -36,4 +36,4 @@ EventUnmarshallerStream.prototype._transform = function(chunk, encoding, callbac
  */
 module.exports = {
     EventUnmarshallerStream: EventUnmarshallerStream
-};
+};

lib/event-stream/int64.js

@@ -33,7 +33,7 @@ Int64.fromNumber = function(number) {
         );
     }
 
-    var bytes = new Uint8Array(8)
+    var bytes = new Uint8Array(8);
     for (
         var i = 7, remaining = Math.abs(Math.round(number));
         i > -1 && remaining > 0;
@@ -90,4 +90,4 @@ function negate(bytes) {
  */
 module.exports = {
     Int64: Int64
-};
+};

lib/event-stream/parse-event.js

@@ -70,4 +70,4 @@ function parseError(message) {
  */
 module.exports = {
     parseEvent: parseEvent
-};
+};

lib/event-stream/parse-message.js

@@ -125,4 +125,4 @@ function parseMessage(message) {
  */
 module.exports = {
     parseMessage: parseMessage
-};
+};

lib/event-stream/split-message.js

@@ -67,4 +67,4 @@ function splitMessage(message) {
  */
 module.exports = {
     splitMessage: splitMessage
-};
+};

lib/event-stream/streaming-create-event-stream.js

@@ -36,4 +36,4 @@ function createEventStream(stream, parser, model) {
  */
 module.exports = {
     createEventStream: createEventStream
-};
+};

lib/event-stream/to-buffer.js

@@ -15,4 +15,4 @@ function toBuffer(data, encoding) {
  */
 module.exports = {
     toBuffer: toBuffer
-};
+};

lib/event_listeners.js

@@ -512,23 +512,23 @@ AWS.EventListeners = {
               } else {
                 struct[subShapeName] = subShape;
               }
-            })
-            return struct
+            });
+            return struct;
           case 'list':
             var list = [];
             AWS.util.arrayEach(shape, function(subShape, index) {
               list.push(filterSensitiveLog(inputShape.member, subShape));
-            })
+            });
             return list;
           case 'map':
             var map = {};
             AWS.util.each(shape, function(key, value) {
               map[key] = filterSensitiveLog(inputShape.value, value);
-            })
+            });
             return map;
           default:
             if (inputShape.isSensitive) {
-              return '***SensitiveInformation***'
+              return '***SensitiveInformation***';
             } else {
               return shape;
             }

lib/http.js

@@ -160,7 +160,7 @@ AWS.HttpRequest = inherit({
   updateEndpoint: function updateEndpoint(endpointStr) {
     var newEndpoint = new AWS.Endpoint(endpointStr);
     this.endpoint = newEndpoint;
-    this.path = newEndpoint.path || '/'
+    this.path = newEndpoint.path || '/';
   }
 });
 

lib/param_validator.js

@@ -113,7 +113,7 @@ AWS.ParamValidator = AWS.util.inherit({
         if (!Object.prototype.hasOwnProperty.call(params, param)) continue;
         // Validate any map key trait constraints
         this.validateMember(shape.key, param,
-                            context + '[key=\'' + param + '\']')
+                            context + '[key=\'' + param + '\']');
         this.validateMember(shape.value, params[param],
                             context + '[\'' + param + '\']');
         mapCount++;

lib/protocol/helpers.js

@@ -19,7 +19,7 @@ function populateHostPrefix(request)  {
     prependEndpointPrefix(request.httpRequest.endpoint, hostPrefix);
     validateHostname(request.httpRequest.endpoint.hostname);
   }
-  return request
+  return request;
 }
 
 /**
@@ -67,15 +67,15 @@ function prependEndpointPrefix(endpoint, prefix) {
  * @api private
  */
 function validateHostname(hostname) {
-  var labels = hostname.split('.')
+  var labels = hostname.split('.');
   //Reference: https://tools.ietf.org/html/rfc1123#section-2
   var hostPattern = /^[a-zA-Z0-9]{1}$|^[a-zA-Z0-9][a-zA-Z0-9\-]*[a-zA-Z0-9]$/;
   util.arrayEach(labels, function(label) {
     if (!label.length || label.length < 1 || label.length > 63) {
       throw util.error(new Error(), {
         code: 'ValidationError',
         message: 'Hostname label length should be between 1 to 63 characters, inclusive.'
-      })
+      });
     }
     if (!hostPattern.test(label)) {
       throw AWS.util.error(new Error(),
@@ -86,4 +86,4 @@ function validateHostname(hostname) {
 
 module.exports = {
   populateHostPrefix: populateHostPrefix
-}
+};