Inline all usings (#2629)

* inline all usings

* simplify inline

* code improvements

* fix

* fix missing inlines

Author: jmklix

src/aws-cpp-sdk-core/source/http/standard/StandardHttpRequest.cpp

@@ -11,28 +11,22 @@
 #include <algorithm>
 #include <cassert>
 
-using Aws::Http::Standard::StandardHttpRequest;
-using Aws::Http::HeaderValueCollection;
-using Aws::Http::Scheme;
-using Aws::Http::URI;
-using Aws::Utils::StringUtils;
-
 static const char* STANDARD_HTTP_REQUEST_LOG_TAG = "StandardHttpRequest";
 
-static bool IsDefaultPort(const URI& uri)
+static bool IsDefaultPort(const Aws::Http::URI& uri)
 {
     switch(uri.GetPort())
     {
         case 80:
-            return uri.GetScheme() == Scheme::HTTP;
+            return uri.GetScheme() == Aws::Http::Scheme::HTTP;
         case 443:
-            return uri.GetScheme() == Scheme::HTTPS;
+            return uri.GetScheme() == Aws::Http::Scheme::HTTPS;
         default:
             return false;
     }
 }
 
-StandardHttpRequest::StandardHttpRequest(const URI& uri, HttpMethod method) :
+Aws::Http::Standard::StandardHttpRequest::StandardHttpRequest(const Aws::Http::URI& uri, Aws::Http::HttpMethod method) :
     HttpRequest(uri, method), 
     bodyStream(nullptr),
     m_responseStreamFactory()
@@ -49,51 +43,51 @@ StandardHttpRequest::StandardHttpRequest(const URI& uri, HttpMethod method) :
     }
 }
 
-HeaderValueCollection StandardHttpRequest::GetHeaders() const
+Aws::Http::HeaderValueCollection Aws::Http::Standard::StandardHttpRequest::GetHeaders() const
 {
     HeaderValueCollection headers;
 
-    for (HeaderValueCollection::const_iterator iter = headerMap.begin(); iter != headerMap.end(); ++iter)
+    for (const auto & iter : headerMap)
     {
-        headers.emplace(HeaderValuePair(iter->first, iter->second));
+        headers.emplace(HeaderValuePair(iter.first, iter.second));
     }
 
     return headers;
 }
 
-const Aws::String& StandardHttpRequest::GetHeaderValue(const char* headerName) const
+const Aws::String& Aws::Http::Standard::StandardHttpRequest::GetHeaderValue(const char* headerName) const
 {
-    auto iter = headerMap.find(StringUtils::ToLower(headerName));
+    auto iter = headerMap.find(Utils::StringUtils::ToLower(headerName));
     assert (iter != headerMap.end());
     if (iter == headerMap.end()) {
-        AWS_LOGSTREAM_ERROR(STANDARD_HTTP_REQUEST_LOG_TAG, "Requested a header value for a missing header key: " << headerName);
-        static const Aws::String EMPTY_STRING = "";
+        AWS_LOGSTREAM_ERROR(STANDARD_HTTP_REQUEST_LOG_TAG, "Requested a header value for a missing header key: " << headerName)
+        static const Aws::String EMPTY_STRING;
         return EMPTY_STRING;
     }
     return iter->second;
 }
 
-void StandardHttpRequest::SetHeaderValue(const char* headerName, const Aws::String& headerValue)
+void Aws::Http::Standard::StandardHttpRequest::SetHeaderValue(const char* headerName, const Aws::String& headerValue)
 {
-    headerMap[StringUtils::ToLower(headerName)] = StringUtils::Trim(headerValue.c_str());
+    headerMap[Utils::StringUtils::ToLower(headerName)] = Utils::StringUtils::Trim(headerValue.c_str());
 }
 
-void StandardHttpRequest::SetHeaderValue(const Aws::String& headerName, const Aws::String& headerValue)
-{
-    headerMap[StringUtils::ToLower(headerName.c_str())] = StringUtils::Trim(headerValue.c_str());
+void Aws::Http::Standard::StandardHttpRequest::SetHeaderValue(const Aws::String &headerName, const Aws::String &headerValue) {
+
+    headerMap[Utils::StringUtils::ToLower(headerName.c_str())] = Utils::StringUtils::Trim(headerValue.c_str());
 }
 
-void StandardHttpRequest::DeleteHeader(const char* headerName)
+void Aws::Http::Standard::StandardHttpRequest::DeleteHeader(const char* headerName)
 {
-    headerMap.erase(StringUtils::ToLower(headerName));
+    headerMap.erase(Utils::StringUtils::ToLower(headerName));
 }
 
-bool StandardHttpRequest::HasHeader(const char* headerName) const
+bool Aws::Http::Standard::StandardHttpRequest::HasHeader(const char* headerName) const
 {
-    return headerMap.find(StringUtils::ToLower(headerName)) != headerMap.end();
+    return headerMap.find(Utils::StringUtils::ToLower(headerName)) != headerMap.end();
 }
 
-int64_t StandardHttpRequest::GetSize() const
+int64_t Aws::Http::Standard::StandardHttpRequest::GetSize() const
 {
     int64_t size = 0;
 
@@ -102,12 +96,12 @@ int64_t StandardHttpRequest::GetSize() const
     return size;
 }
 
-const Aws::IOStreamFactory& StandardHttpRequest::GetResponseStreamFactory() const 
+const Aws::IOStreamFactory& Aws::Http::Standard::StandardHttpRequest::GetResponseStreamFactory() const
 { 
     return m_responseStreamFactory; 
 }
 
-void StandardHttpRequest::SetResponseStreamFactory(const Aws::IOStreamFactory& factory) 
+void Aws::Http::Standard::StandardHttpRequest::SetResponseStreamFactory(const Aws::IOStreamFactory& factory)
 { 
     m_responseStreamFactory = factory; 
 }