Skip to content

Commit 1360e74

Browse files
committed
[Test] In test_update_slurm, use flexible instance types for spot instances to reduce the risk of ICEs.
Signed-off-by: Giacomo Marciani <[email protected]>
1 parent 2ec9592 commit 1360e74

File tree

3 files changed

+26
-2
lines changed

3 files changed

+26
-2
lines changed

tests/integration-tests/tests/update/test_update.py

Lines changed: 20 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -133,7 +133,16 @@ def test_update_slurm(region, pcluster_config_reader, s3_bucket_factory, cluster
133133
"instances": [
134134
{
135135
"instance_type": "t3.small",
136-
}
136+
},
137+
{
138+
"instance_type": "t3a.small",
139+
},
140+
{
141+
"instance_type": "t3.medium",
142+
},
143+
{
144+
"instance_type": "t3a.medium",
145+
},
137146
],
138147
"expected_running_instances": 1,
139148
"expected_power_saved_instances": 9,
@@ -240,7 +249,16 @@ def test_update_slurm(region, pcluster_config_reader, s3_bucket_factory, cluster
240249
"instances": [
241250
{
242251
"instance_type": "t3.small",
243-
}
252+
},
253+
{
254+
"instance_type": "t3a.small",
255+
},
256+
{
257+
"instance_type": "t3.medium",
258+
},
259+
{
260+
"instance_type": "t3a.medium",
261+
},
244262
],
245263
"expected_running_instances": 0,
246264
"expected_power_saved_instances": 10,

tests/integration-tests/tests/update/test_update/test_update_slurm/pcluster.config.update.yaml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -59,6 +59,9 @@ Scheduling:
5959
- Name: queue1-i3 # New compute resource
6060
Instances:
6161
- InstanceType: t3.small
62+
- InstanceType: t3a.small
63+
- InstanceType: t3.medium
64+
- InstanceType: t3a.medium
6265
# Removed MinCount
6366
Networking:
6467
SubnetIds:

tests/integration-tests/tests/update/test_update/test_update_slurm/pcluster.config.yaml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -51,6 +51,9 @@ Scheduling:
5151
- Name: queue1-i2
5252
Instances:
5353
- InstanceType: t3.small
54+
- InstanceType: t3a.small
55+
- InstanceType: t3.medium
56+
- InstanceType: t3a.medium
5457
MinCount: 1
5558
Networking:
5659
SubnetIds:

0 commit comments

Comments
 (0)