Update nodejs and CDK version to latest (#315)

Deprecate Amazon Linux 2 because it can't run latest nodejs.

Update installer to check OS version.

Clean up the SlurmPlugin.py to remove legacy code that was causing an import
error with python 3.12.

Resolves #278

Resolves #279

Author: cartalla

.gitignore

@@ -11,3 +11,5 @@ security_scan/cfn_nag.log
 security_scan/ScoutSuite
 
 __pycache__
+
+.venv*

docs/deployment-prerequisites.md

@@ -4,10 +4,9 @@ This page shows common prerequisites that need to be done before deployment.
 
 ## Deployment Server/Instance Requirements
 
-The deployment process was developed and tested using Amazon Linux 2.
-It has also been tested on RHEL 8 and RHEL 9.
-An easy way to create a deployment instance is to use AWS CloudShell.
-This will give you a code editor IDE and shell environment that you can use to deploy the cluster.
+The deployment process was developed and tested using Mac OS and RHEL 8.
+Amazon Linux 2 doesn't support the current version of node.js so it cannot be used.
+It has also been tested on RHEL 9 and should work on Rocky Linux 8 and 9.
 
 If the required packages aren't installed then you will need sudo or root access on the instance.
 

setup.sh

@@ -10,14 +10,50 @@ pushd $repodir
 
 arch=$(uname -m)
 if [[ $arch == 'x86_64' ]]; then
-    shortarch='x86'
+    shortarch='x64'
 else
     shortarch=$arch
 fi
 if [[ $(uname -s) == 'Linux' ]]; then
     os=linux
     installer='sudo yum -y'
     shellrc='.bashrc'
+    if [ -f /etc/os-release ]; then
+        . /etc/os-release
+        case "$ID-$VERSION_ID" in
+            "amzn-2"*)
+                echo "error: Unsupported OS $(uname -s)"
+                return 1
+                ;;
+            "centos-7"*)
+                echo "error: Unsupported OS $(uname -s)"
+                return 1
+                ;;
+            "centos-8"*)
+                echo "error: Unsupported OS $(uname -s)"
+                return 1
+                ;;
+            "rhel-7"*)
+                echo "error: Unsupported OS $(uname -s)"
+                return 1
+                ;;
+            "rhel-8"*)
+                distro="rhel8"
+                ;;
+            "rhel-9"*)
+                distro="rhel9"
+                ;;
+            "rocky-8"*)
+                distro="rocky8"
+                ;;
+            "rocky-9"*)
+                distro="rocky9"
+                ;;
+        esac
+    else
+        echo "error: Unsupported OS $(uname -s)"
+        return 1
+    fi
 elif [[ $(uname -s) == 'Darwin' ]]; then
     os=macos
     installer='brew'
@@ -61,12 +97,7 @@ echo "Using python $python_version"
 
 # Check nodejs version
 # https://nodejs.org/en/about/previous-releases
-if [[ $os == 'macos' ]]; then
-    required_nodejs_version=20.19.0
-else
-    # linux
-    required_nodejs_version=16.20.2
-fi
+required_nodejs_version=20.19.0
 # required_nodejs_version=18.20.2
 # On Amazon Linux 2 and nodejs 18.20.2 I get the following errors:
 #     node: /lib64/libm.so.6: version `GLIBC_2.27' not found (required by node)
@@ -107,7 +138,10 @@ if [[ $nodejs_version != $required_nodejs_version ]]; then
         nodedir=node-v${required_nodejs_version}-darwin-${shortarch}
     fi
     tarball=${nodedir}.tar.xz
-    wget https://nodejs.org/dist/v${required_nodejs_version}/$tarball
+    if ! wget https://nodejs.org/dist/v${required_nodejs_version}/$tarball; then
+        echo "error: Couldn't download nodejs from https://nodejs.org/dist/v${required_nodejs_version}/$tarball."
+        return 1
+    fi
     tar -xf $tarball
     rm $tarball
     cat >> ~/$shellrc << EOF
@@ -117,6 +151,7 @@ export PATH=$HOME/$nodedir/bin:\$PATH
 EOF
     source ~/$shellrc
     popd
+    nodejs_version=$required_nodejs_version
 fi
 
 echo "Using nodejs version $nodejs_version"
@@ -138,6 +173,7 @@ if [[ $cdk_version != $CDK_VERSION ]]; then
     if ! npm install -g --force aws-cdk@$CDK_VERSION; then
         sudo npm install -g --force aws-cdk@$CDK_VERSION
     fi
+    cdk_version=$CDK_VERSION
 fi
 echo "Using CDK $cdk_version"