Skip to content

Commit a2dc2db

Browse files
authored
Remove dockerhub login step and use ECR public gallery ubuntu image (#78)
This is required so that we do not need to support dockerhub and its credentials. 1. Remove dockerhub login step from the codebuild spec file. 2. Use [ECR public gallery ubuntu image](https://gallery.ecr.aws/ubuntu/ubuntu) in the Canary Docker Image instead ### Testing For testing I added this commit on top of the `canary` branch and pushed to a new upstream branch [`docker-on-ecr-on-canary-branch`](https://github.com/aws-controllers-k8s/sagemaker-controller/tree/docker-on-ecr-on-canary-branch). Then ran the canary test job on this branch.
1 parent 0b96ed2 commit a2dc2db

File tree

2 files changed

+1
-4
lines changed

2 files changed

+1
-4
lines changed

test/canary/Dockerfile.canary

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
FROM ubuntu:18.04
1+
FROM public.ecr.aws/ubuntu/ubuntu:18.04
22

33
# Build time parameters
44
ARG SERVICE=sagemaker

test/canary/canary.buildspec.yaml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,9 +10,6 @@ phases:
1010
- aws ecr get-login-password --region $CLUSTER_REGION | docker login --username AWS --password-stdin $ECR_CACHE_URI || true
1111
- docker pull ${ECR_CACHE_URI}:latest --quiet || true
1212

13-
# Login to dockerhub to avoid hitting throttle limit
14-
- docker login -u $DOCKER_CONFIG_USERNAME -p $DOCKER_CONFIG_PASSWORD
15-
1613
# Build test image
1714
- >
1815
docker build -f ./test/canary/Dockerfile.canary . -t ${ECR_CACHE_URI}:latest

0 commit comments

Comments
 (0)