Return an error message if snapshot is not ready for deleting (#77)

Issue #, if available:
If `snapshot` is not ready for deleting and is called by `sdkDelete`, it will have an error `InvalidSnapshotStateFault`.

Description of changes:
Check whether `snapshot` is in the `status` to be deleted. If not, then output an error message.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Author: kyriechen96

apis/v1alpha1/ack-generate-metadata.yaml

@@ -1,5 +1,5 @@
 ack_generate_info:
-  build_date: "2023-03-16T20:02:03Z"
+  build_date: "2023-03-20T20:22:37Z"
   build_hash: 0888419ec6825035cae1fdee2ceffd7c1ac73ca8
   go_version: go1.19
   version: v0.24.3-5-g0888419

pkg/resource/snapshot/sdk.go

@@ -2,6 +2,7 @@ package snapshot
 
 import (
 	"errors"
+	"fmt"
 	svcapitypes "github.com/aws-controllers-k8s/memorydb-controller/apis/v1alpha1"
 	ackv1alpha1 "github.com/aws-controllers-k8s/runtime/apis/core/v1alpha1"
 	ackrequeue "github.com/aws-controllers-k8s/runtime/pkg/requeue"
@@ -11,14 +12,20 @@ import (
 
 var (
 	condMsgCurrentlyDeleting string = "snapshot currently being deleted"
+	availableStatus          string = "available"
 	deleteStatus             string = "deleting"
+	failedStatus             string = "failed"
 )
 
 var (
 	requeueWaitWhileDeleting = ackrequeue.NeededAfter(
 		errors.New("delete is in progress"),
 		ackrequeue.DefaultRequeueAfterDuration,
 	)
+	requeueWaitSnapshotIsReadyForDeleting = ackrequeue.NeededAfter(
+		fmt.Errorf("snapshot is not ready for deletion - must be in either %q or %q state", availableStatus, failedStatus),
+		ackrequeue.DefaultRequeueAfterDuration,
+	)
 )
 
 // isDeleting returns true if supplied snapshot resource state is 'deleting'
@@ -30,6 +37,15 @@ func isDeleting(r *resource) bool {
 	return status == deleteStatus
 }
 
+// isNotReadyForDeleting returns true if supplied cluster resource state is not 'deleting', 'available', or 'failed'
+func isNotReadyForDeleting(r *resource) bool {
+	if r == nil || r.ko.Status.Status == nil {
+		return false
+	}
+	status := *r.ko.Status.Status
+	return status != deleteStatus && status != availableStatus && status != failedStatus
+}
+
 func (rm *resourceManager) setSnapshotOutput(
 	r *resource,
 	obj *svcsdk.Snapshot,

pkg/resource/snapshot/utility.go

@@ -13,4 +13,9 @@
 		// - reconciler.handleRequeues() is not invoked for delete code path.
 		// TODO: return err as nil when reconciler is updated.
 		return r, requeueWaitWhileDeleting
+	}
+
+	if isNotReadyForDeleting(r) {
+	    // return a requeue if snapshot is not ready to be deleted
+	    return r, requeueWaitSnapshotIsReadyForDeleting
 	}